Issue 6296079: Removed static destructors in DependencyGraphBuilder.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6296079: Removed static destructors in DependencyGraphBuilder. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by mvujovic

Modified:
11 years, 11 months ago

Reviewers:
kbr1, kbr, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Removed static destructors in DependencyGraphBuilder.

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -23 lines)			Patch
	M	src/compiler/depgraph/DependencyGraphBuilder.h	View		3 chunks	+6 lines, -9 lines	0 comments	Download
	M	src/compiler/depgraph/DependencyGraphBuilder.cpp	View		5 chunks	+7 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mvujovic

Hi guys, This is preventing a deps roll. Here was Ken's message: """ The build ...

11 years, 11 months ago (2012-06-16 02:23:41 UTC) #1

Hi guys,

This is preventing a deps roll.

Here was Ken's message:

"""
The build bots will fail like this:

# Static initializers in src/sconsbuild/Release/chrome:
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kLeftSubtree
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kLeftSubtree+0x18
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kLeftSubtree+0x20
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kLeftSubtree+0x28
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kLeftSubtree+0x30
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kLeftSubtree+0x38
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kLeftSubtree+0x8
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kRightSubtree
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kRightSubtree+0x18
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kRightSubtree+0x20
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kRightSubtree+0x28
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kRightSubtree+0x30
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kRightSubtree+0x38
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::kRightSubtree+0x8
# DependencyGraphBuilder.cpp
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::TSubtreePlaceholder::~TSubtreePlaceholder()
# DependencyGraphBuilder.cpp vtable for
TDependencyGraphBuilder::TLeftmostSymbolMaintainer::TSubtreePlaceholder+0x10
# DependencyGraphBuilder.cpp __cxa_atexit@plt [registers a dtor to run at exit]

http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/31767/steps/...

At some time since r1046, static initializers were added. It looks
like r1101, the shader timing restrictions patch.
"""

mvujovic

11 years, 11 months ago (2012-06-16 02:46:19 UTC) #3

On 2012/06/16 02:32:12, kbr1 wrote:
> LGTM

Thanks, Ken. Committed in r1154.

Expand All Messages | Collapse All Messages