Issue 62960043: code review 62960043: runtime/pprof: fix arm build after CL 61270043

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 62960043: code review 62960043: runtime/pprof: fix arm build after CL 61270043 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by rsc

Modified:
11 years, 4 months ago

Reviewers:
dvyukov

CC:
golang-codereviews

Visibility:
Public.

Description

runtime/pprof: fix arm build after CL 61270043

Patch Set 1 #

Patch Set 2 : diff -r 6d069d383628 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3f8273c461a5 https://code.google.com/p/go/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/pprof/pprof_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello dvyukov (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 4 months ago (2014-02-13 06:16:18 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=6624f422f070 *** runtime/pprof: fix arm build after CL 61270043 TBR=dvyukov CC=golang-codereviews https://codereview.appspot.com/62960043

11 years, 4 months ago (2014-02-13 06:16:24 UTC) #2

dvyukov

LGTM but I am a bit confused why there are entries >etext on linux/arm..

11 years, 4 months ago (2014-02-13 06:28:57 UTC) #3

rsc

On Thu, Feb 13, 2014 at 1:28 AM, <dvyukov@google.com> wrote: > LGTM > but I ...

11 years, 4 months ago (2014-02-13 06:36:21 UTC) #4

dvyukov

11 years, 4 months ago (2014-02-13 06:45:23 UTC) #5

On Thu, Feb 13, 2014 at 10:36 AM, Russ Cox <rsc@golang.org> wrote:
> On Thu, Feb 13, 2014 at 1:28 AM, <dvyukov@google.com> wrote:
>>
>> LGTM
>> but I am a bit confused why there are entries >etext on linux/arm..
>
>
> hmm. maybe the problem is that each of the dummy functions is only 1 byte,
> so adding the PC quantum ends up being in the next function.

Why is then PCquantum=4, if min instruction size is 1?..

ExternalCode is used when PC passed to sigprof > etext. Why are there
PCs>etext on arm?..

Expand All Messages | Collapse All Messages