Issue 6295101: cmd/jujud: remove dummy environ import from provisioning agent

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6295101: cmd/jujud: remove dummy environ import from provisioning agent

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rog

Modified:
11 years, 10 months ago

Reviewers:
mp+110977

Visibility:
Public.

Description

cmd/jujud: remove dummy environ import from provisioning agent This was causing jujud to panic when run in the cloud. https://code.launchpad.net/~rogpeppe/juju-core/remove-dummy-import/+merge/110977 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: remote dummy environ import from provisioning agent #

Total comments: 1

Patch Set 3 : cmd/jujud: remove dummy environ import from provisioning agent #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/jujud/provisioning.go	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

LGTM. The tests can import dummy if they need them. https://codereview.appspot.com/6295101/diff/2001/cmd/jujud/provisioning.go File cmd/jujud/provisioning.go (left): https://codereview.appspot.com/6295101/diff/2001/cmd/jujud/provisioning.go#oldcode14 ...

11 years, 10 months ago (2012-06-19 11:20:38 UTC) #3

rog

11 years, 10 months ago (2012-06-19 14:01:40 UTC) #5

*** Submitted:

cmd/jujud: remove dummy environ import from provisioning agent

This was causing jujud to panic when run in the cloud.

R=fwereade, dfc, niemeyer
CC=
https://codereview.appspot.com/6295101

Expand All Messages | Collapse All Messages