Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 6294079: Consistent bounds for slurs; issue 427 and 379 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Keith
Modified:
7 years, 1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Consistent bounds for slurs; issue 427 and 379 Bounds for piano pedal spanners; issue 492 The eventual commits will add a \mark at the line-break in 'piano-pedal-bracket.ly' to serve as a regtest for issue 492

Patch Set 1 : with updated regtest #

Patch Set 2 : without regtest update #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -41 lines) Patch
M lily/include/slur-scoring.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/phrasing-slur-engraver.cc View 1 chunk +19 lines, -1 line 1 comment Download
M lily/piano-pedal-bracket.cc View 2 chunks +3 lines, -1 line 0 comments Download
M lily/slur-scoring.cc View 4 chunks +13 lines, -12 lines 1 comment Download
M lily/spanner.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 1
Keith
7 years, 3 months ago (2012-06-16 08:34:20 UTC) #1
http://codereview.appspot.com/6294079/diff/4001/lily/phrasing-slur-engraver.cc
File lily/phrasing-slur-engraver.cc (right):

http://codereview.appspot.com/6294079/diff/4001/lily/phrasing-slur-engraver.c...
lily/phrasing-slur-engraver.cc:284: {
Synchronized with slur-engraver.cc

http://codereview.appspot.com/6294079/diff/4001/lily/slur-scoring.cc
File lily/slur-scoring.cc (left):

http://codereview.appspot.com/6294079/diff/4001/lily/slur-scoring.cc#oldcode440
lily/slur-scoring.cc:440: return item;
We do not want just one random item among those that slurs should avoid;  we
want the total extent of all of them.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b