Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 6278047: code review 6278047: time: make Format 2.7x faster (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by rsc
Modified:
2 years, 11 months ago
Reviewers:
albert.strasheim
CC:
r, golang-dev
Visibility:
Public.

Description

time: make Format 2.7x faster benchmark old ns/op new ns/op delta BenchmarkFormat 2495 937 -62.44% BenchmarkFormatNow 2308 889 -61.48% Update issue 3679.

Patch Set 1 #

Patch Set 2 : diff -r a2cb3130bd86 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a2cb3130bd86 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r daebd1be3d41 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -199 lines) Patch
M src/pkg/time/format.go View 1 13 chunks +211 lines, -188 lines 0 comments Download
M src/pkg/time/time.go View 1 4 chunks +42 lines, -3 lines 0 comments Download
M src/pkg/time/time_test.go View 1 1 chunk +11 lines, -2 lines 0 comments Download
M src/pkg/time/zoneinfo.go View 1 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
2 years, 11 months ago (2012-06-03 14:36:26 UTC) #1
rsc
I moved this to a new CL to avoid the confusing history of the old ...
2 years, 11 months ago (2012-06-03 14:37:53 UTC) #2
r
LGTM cool how the parsing code hardly changes
2 years, 11 months ago (2012-06-03 14:52:32 UTC) #3
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=bff65816ad27 *** time: make Format 2.7x faster benchmark old ns/op new ns/op ...
2 years, 11 months ago (2012-06-03 15:08:29 UTC) #4
albert.strasheim
2 years, 11 months ago (2012-06-04 11:29:53 UTC) #5
This change caused a regression for us.

http://code.google.com/p/go/issues/detail?id=3701

On 2012/06/03 15:08:29, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=bff65816ad27 ***
> 
> time: make Format 2.7x faster
> 
> benchmark             old ns/op    new ns/op    delta
> BenchmarkFormat            2495          937  -62.44%
> BenchmarkFormatNow         2308          889  -61.48%
> 
> Update issue 3679.
> 
> R=r
> CC=golang-dev
> http://codereview.appspot.com/6278047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5