Issue 6278047: code review 6278047: time: make Format 2.7x faster

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6278047: code review 6278047: time: make Format 2.7x faster (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rsc

Modified:
11 years, 10 months ago

Reviewers:
albert.strasheim

CC:
r, golang-dev

Visibility:
Public.

Description

time: make Format 2.7x faster benchmark old ns/op new ns/op delta BenchmarkFormat 2495 937 -62.44% BenchmarkFormatNow 2308 889 -61.48% Update issue 3679.

Patch Set 1 #

Patch Set 2 : diff -r a2cb3130bd86 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a2cb3130bd86 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r daebd1be3d41 https://go.googlecode.com/hg/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+272 lines, -199 lines)			Patch
M	src/pkg/time/format.go	View	1	13 chunks	+211 lines, -188 lines	0 comments	Download
M	src/pkg/time/time.go	View	1	4 chunks	+42 lines, -3 lines	0 comments	Download
M	src/pkg/time/time_test.go	View	1	1 chunk	+11 lines, -2 lines	0 comments	Download
M	src/pkg/time/zoneinfo.go	View	1	1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 10 months ago (2012-06-03 14:36:26 UTC) #1

rsc

I moved this to a new CL to avoid the confusing history of the old ...

11 years, 10 months ago (2012-06-03 14:37:53 UTC) #2

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=bff65816ad27 *** time: make Format 2.7x faster benchmark old ns/op new ns/op ...

11 years, 10 months ago (2012-06-03 15:08:29 UTC) #4

albert.strasheim

11 years, 10 months ago (2012-06-04 11:29:53 UTC) #5

This change caused a regression for us.

http://code.google.com/p/go/issues/detail?id=3701

On 2012/06/03 15:08:29, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=bff65816ad27 ***
> 
> time: make Format 2.7x faster
> 
> benchmark             old ns/op    new ns/op    delta
> BenchmarkFormat            2495          937  -62.44%
> BenchmarkFormatNow         2308          889  -61.48%
> 
> Update issue 3679.
> 
> R=r
> CC=golang-dev
> http://codereview.appspot.com/6278047

Expand All Messages | Collapse All Messages