Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1384)

Issue 62780044: Pass environs.BootstrapContext to Prepare

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by axw
Modified:
10 years, 3 months ago
Reviewers:
dimitern, mp+206082, fwereade
Visibility:
Public.

Description

Pass environs.BootstrapContext to Prepare This is part one of fixing lp:1279259. In this CL, we pass context to Prepare, giving providers an opportunity to prompt the user to initialise an environment. Passing context was previously restricted to Bootstrap and EnableBootstrapStorage; this is insufficient, as there are many ways to prepare an environment. It is currently possible to successfully "Prepare" and environment, but for the result to be unusable in the manual provider (e.g. if the bootstrap-host address is invalid). We should that a successfully Prepared environment should be able to be Destroyed (with force). The next CL will remove BootstrapStorager and fix lp:1279259 by initialising the ubuntu user during Prepare. https://code.launchpad.net/~axwalk/juju-core/lp1279259-part1-prepare-context/+merge/206082 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Pass environs.BootstrapContext to Prepare #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -270 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/cmd.go View 1 chunk +17 lines, -2 lines 0 comments Download
M cmd/juju/bootstrap.go View 4 chunks +3 lines, -21 lines 0 comments Download
M cmd/juju/bootstrap_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/destroyenvironment_test.go View 5 chunks +5 lines, -5 lines 0 comments Download
M cmd/juju/synctools.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/synctools_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/plugins/juju-metadata/imagemetadata.go View 3 chunks +11 lines, -4 lines 0 comments Download
M cmd/plugins/juju-metadata/imagemetadata_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/plugins/juju-metadata/toolsmetadata_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/plugins/juju-metadata/validateimagemetadata.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/plugins/juju-metadata/validatetoolsmetadata.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/plugins/juju-restore/restore.go View 5 chunks +3 lines, -26 lines 0 comments Download
M environs/bootstrap/bootstrap_test.go View 7 chunks +9 lines, -14 lines 0 comments Download
M environs/emptystorage_test.go View 2 chunks +4 lines, -2 lines 0 comments Download
M environs/imagemetadata/urls_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/interface.go View 2 chunks +4 lines, -4 lines 0 comments Download
M environs/jujutest/livetests.go View 5 chunks +5 lines, -5 lines 0 comments Download
M environs/jujutest/tests.go View 4 chunks +3 lines, -7 lines 0 comments Download
M environs/manual/bootstrap.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/manual/bootstrap_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M environs/open.go View 3 chunks +4 lines, -4 lines 0 comments Download
M environs/open_test.go View 13 chunks +26 lines, -15 lines 0 comments Download
M environs/storage/storage_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/sync/sync_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/testing/bootstrap.go View 2 chunks +0 lines, -23 lines 0 comments Download
M environs/tools/storage_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/tools/tools_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/tools/urls_test.go View 1 chunk +1 line, -1 line 0 comments Download
M juju/apiconn_test.go View 1 chunk +3 lines, -2 lines 0 comments Download
M juju/conn_test.go View 6 chunks +18 lines, -16 lines 0 comments Download
M juju/testing/conn.go View 1 chunk +2 lines, -2 lines 0 comments Download
M provider/azure/environprovider.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/common/bootstrap.go View 4 chunks +7 lines, -7 lines 0 comments Download
M provider/common/bootstrap_test.go View 13 chunks +19 lines, -28 lines 0 comments Download
M provider/dummy/config_test.go View 2 chunks +4 lines, -2 lines 0 comments Download
M provider/dummy/environs.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/ec2/config_test.go View 2 chunks +4 lines, -3 lines 0 comments Download
M provider/ec2/ec2.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/ec2/local_test.go View 7 chunks +6 lines, -10 lines 0 comments Download
M provider/joyent/config_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/joyent/provider.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/local/config_test.go View 2 chunks +2 lines, -3 lines 0 comments Download
M provider/local/environ.go View 1 chunk +2 lines, -2 lines 0 comments Download
M provider/local/environ_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M provider/local/environprovider.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/local/environprovider_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/maas/environ_whitebox_test.go View 4 chunks +5 lines, -9 lines 0 comments Download
M provider/maas/environprovider.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/maas/environprovider_test.go View 2 chunks +4 lines, -2 lines 0 comments Download
M provider/manual/environ.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/manual/environ_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M provider/manual/provider.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/manual/provider_test.go View 4 chunks +4 lines, -3 lines 0 comments Download
M provider/openstack/config_test.go View 2 chunks +4 lines, -3 lines 0 comments Download
M provider/openstack/live_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/openstack/local_test.go View 8 chunks +8 lines, -12 lines 0 comments Download
M provider/openstack/provider.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/common/environwatcher_test.go View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
axw
Please take a look.
10 years, 3 months ago (2014-02-13 02:56:44 UTC) #1
dimitern
The diff is missing, repropose please.
10 years, 3 months ago (2014-02-13 09:37:04 UTC) #2
axw
Please take a look.
10 years, 3 months ago (2014-02-13 09:53:42 UTC) #3
fwereade
10 years, 3 months ago (2014-02-17 10:10:23 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b