state: Changed relation service mapping in topology.

state: Changed relation service mapping in topology.

The first approach mapped roles to service key and relation
name opposite to todays Python implementation. This reduces
the flexibility for future purposes (e.g. multiple peers).
So the mapping has now been changed back from service keys
to relation role and name.

https://code.launchpad.net/~themue/juju/go-state-topology-service-mapping/+merge/108570

(do not edit description out of merge proposal)

[TheMue, 2012-06-04 14:11:33]

Please take a look.

[TheMue, 2012-06-04 14:59:49]

Please take a look.

[niemeyer, 2012-06-06 12:08:31]

Very nice. Only a couple of details:

https://codereview.appspot.com/6268049/diff/3001/state/topology.go
File state/topology.go (right):

https://codereview.appspot.com/6268049/diff/3001/state/topology.go#newcode73
state/topology.go:73: RelationRole RelationRole
"relation-role" as a tag at the end (see field below).

https://codereview.appspot.com/6268049/diff/3001/state/topology.go#newcode489
state/topology.go:489: serviceKey, err := t.ServiceKey(endpoint.ServiceName)
If this service is not found, the error should be of type NoRelationError,
otherwise the documentation is wrong.

[TheMue, 2012-06-06 14:01:21]

Please take a look.

https://codereview.appspot.com/6268049/diff/3001/state/topology.go
File state/topology.go (right):

https://codereview.appspot.com/6268049/diff/3001/state/topology.go#newcode73
state/topology.go:73: RelationRole RelationRole
On 2012/06/06 12:08:31, niemeyer wrote:
> "relation-role" as a tag at the end (see field below).

Done.

https://codereview.appspot.com/6268049/diff/3001/state/topology.go#newcode489
state/topology.go:489: serviceKey, err := t.ServiceKey(endpoint.ServiceName)
On 2012/06/06 12:08:31, niemeyer wrote:
> If this service is not found, the error should be of type NoRelationError,
> otherwise the documentation is wrong.

Done.

[niemeyer, 2012-06-06 15:19:27]

Thanks, LGTM.

[TheMue, 2012-06-06 15:32:24]

*** Submitted:

state: Changed relation service mapping in topology.

The first approach mapped roles to service key and relation
name opposite to todays Python implementation. This reduces
the flexibility for future purposes (e.g. multiple peers).
So the mapping has now been changed back from service keys
to relation role and name.

R=
CC=
https://codereview.appspot.com/6268049