Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(402)

Issue 6268046: code review 6268046: path/filepath: fix test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by mikio
Modified:
1 year, 10 months ago
Reviewers:
rsc
CC:
golang-dev, r
Visibility:
Public.

Description

path/filepath: fix test

Make it possible to run test over symlinked GOROOT.

Patch Set 1 : diff -r bff65816ad27 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r bff65816ad27 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bff65816ad27 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/pkg/path/filepath/path_test.go View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 10 months ago #1
r
LGTM
1 year, 10 months ago #2
mikio
*** Submitted as http://code.google.com/p/go/source/detail?r=912fdfb20cc6 *** path/filepath: fix test Make it possible to run test over ...
1 year, 10 months ago #3
rsc
1 year, 10 months ago #4
okay i guess but lots of things break when $GOROOT points at a
symlink. don't do that. :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5