Issue 6268046: code review 6268046: path/filepath: fix test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6268046: code review 6268046: path/filepath: fix test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by mikio

Modified:
11 years, 10 months ago

Reviewers:
rsc

CC:
golang-dev, r

Visibility:
Public.

path/filepath: fix test Make it possible to run test over symlinked GOROOT.

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/pkg/path/filepath/path_test.go	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 4

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 10 months ago (2012-06-04 00:37:46 UTC) #1

mikio

*** Submitted as http://code.google.com/p/go/source/detail?r=912fdfb20cc6 *** path/filepath: fix test Make it possible to run test over ...

11 years, 10 months ago (2012-06-04 00:57:41 UTC) #3

rsc

11 years, 10 months ago (2012-06-04 14:18:26 UTC) #4

okay i guess but lots of things break when $GOROOT points at a
symlink. don't do that. :-)