Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(451)

Issue 6261055: state: add state.Environment (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by dfc
Modified:
9 years ago
Reviewers:
mp+108109
Visibility:
Public.

Description

state: add state.Environment This func provides direct access to the current environment configuration as a *ConfigNode. This is used buy jujut and is needed for testing the provisioning agent as state.readConfigNode() is not exported. https://code.launchpad.net/~dave-cheney/juju/go-state-add-environment/+merge/108109 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: add state.Environment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M state/state.go View 1 chunk +5 lines, -0 lines 0 comments Download
M state/state_test.go View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dfc
Please take a look.
9 years ago (2012-05-31 07:22:52 UTC) #1
niemeyer
LGTM, but can you please add a trivial test before submitting?
9 years ago (2012-06-01 13:42:24 UTC) #2
dfc
will do. i had one before but it was so trivial it didnt seem worth ...
9 years ago (2012-06-01 13:47:37 UTC) #3
dfc
9 years ago (2012-06-03 22:11:47 UTC) #4
*** Submitted:

state: add state.Environment

This func provides direct access to the current environment
configuration as a *ConfigNode. This is used buy jujut and
is needed for testing the provisioning agent as 
state.readConfigNode() is not exported.

R=niemeyer
CC=
https://codereview.appspot.com/6261055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b