Issue 6260048: environs: read series from /etc/lsb-release

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6260048: environs: read series from /etc/lsb-release

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rog

Modified:
11 years, 10 months ago

Reviewers:
mp+107751

Visibility:
Public.

Description

environs: read series from /etc/lsb-release https://code.launchpad.net/~rogpeppe/juju/go-environs-read-series/+merge/107751 (do not edit description out of merge proposal)

Patch Set 2 : environs: read series from /etc/lsb-release #

Total comments: 5

Patch Set 3 : environs: read series from /etc/lsb-release #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -2 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
A	environs/export_test.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	environs/tools.go	View	1 2	1 chunk	+15 lines, -2 lines	0 comments	Download
M	environs/tools_test.go	View	1 2	1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

LGTM given the details below https://codereview.appspot.com/6260048/diff/2001/environs/tools.go File environs/tools.go (right): https://codereview.appspot.com/6260048/diff/2001/environs/tools.go#newcode19 environs/tools.go:19: // TODO find out ...

11 years, 10 months ago (2012-05-29 12:28:41 UTC) #3

rog

11 years, 10 months ago (2012-05-29 13:17:56 UTC) #4

*** Submitted:

environs: read series from /etc/lsb-release

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6260048

Expand All Messages | Collapse All Messages