Issue 62600043: code review 62600043: misc/emacs: actually use point argument that is passed ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 62600043: code review 62600043: misc/emacs: actually use point argument that is passed ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by Dominik Honnef

Modified:
11 years, 4 months ago

Reviewers:
adonovan

CC:
adonovan, golang-codereviews

Visibility:
Public.

Description

misc/emacs: actually use point argument that is passed to godef--call

Patch Set 1 #

Patch Set 2 : diff -r 300960240fcc https://code.google.com/p/go #

Patch Set 3 : diff -r 300960240fcc https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	misc/emacs/go-mode.el	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Dominik Honnef

Hello adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2014-02-12 23:23:46 UTC) #1

adonovan

On 2014/02/12 23:23:46, Dominik Honnef wrote: > Hello mailto:adonovan@google.com (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like ...

11 years, 4 months ago (2014-02-19 02:51:08 UTC) #2

adonovan

11 years, 4 months ago (2014-02-19 02:51:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=094dc1dbd941 ***

misc/emacs: actually use point argument that is passed to godef--call

LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://codereview.appspot.com/62600043

Committer: Alan Donovan <adonovan@google.com>

Expand All Messages | Collapse All Messages