Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2447)

Issue 6259062: add AssignmentPolicy to Environ

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by fwereade
Modified:
9 years ago
Reviewers:
mp+108303
Visibility:
Public.

Description

add AssignmentPolicy to Environ This is very likely to migrate to a Settings type at some stage, but I don't think that's justified yet. https://code.launchpad.net/~fwereade/juju/go-environ-placement-policy/+merge/108303 Requires: https://code.launchpad.net/~fwereade/juju/go-place-unit/+merge/108158 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : add AssignmentPolicy to Environ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M environs/dummy/environs.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M environs/ec2/ec2.go View 1 1 chunk +6 lines, -0 lines 0 comments Download
M environs/ec2/local_test.go View 1 2 chunks +4 lines, -0 lines 0 comments Download
M environs/interface.go View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
fwereade
Please take a look.
9 years ago (2012-06-01 08:12:31 UTC) #1
niemeyer
LGTM
9 years ago (2012-06-05 19:34:28 UTC) #2
fwereade
9 years ago (2012-06-06 10:56:41 UTC) #3
*** Submitted:

add AssignmentPolicy to Environ

This is very likely to migrate to a Settings type at some stage, but I don't
think that's justified yet.

R=niemeyer
CC=
https://codereview.appspot.com/6259062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b