Issue 6259062: add AssignmentPolicy to Environ

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6259062: add AssignmentPolicy to Environ

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by fwereade

Modified:
11 years, 10 months ago

Reviewers:
mp+108303

Visibility:
Public.

Description

add AssignmentPolicy to Environ This is very likely to migrate to a Settings type at some stage, but I don't think that's justified yet. https://code.launchpad.net/~fwereade/juju/go-environ-placement-policy/+merge/108303 Requires: https://code.launchpad.net/~fwereade/juju/go-place-unit/+merge/108158 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : add AssignmentPolicy to Environ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/dummy/environs.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	environs/ec2/local_test.go	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	environs/interface.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

11 years, 10 months ago (2012-06-06 10:56:41 UTC) #3

*** Submitted:

add AssignmentPolicy to Environ

This is very likely to migrate to a Settings type at some stage, but I don't
think that's justified yet.

R=niemeyer
CC=
https://codereview.appspot.com/6259062

Expand All Messages | Collapse All Messages