Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1671)

Issue 6258067: code review 6258067: runtime: add arm soft division and modulo benchmarks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by dfc
Modified:
10 years, 5 months ago
Reviewers:
CC:
minux1, rsc, golang-dev
Visibility:
Public.

Description

runtime: add arm soft division and modulo benchmarks arm soft div and mod performance plays an important part in runtime performance. The currently implementation is very stable, but we believe we can best it. This benchmark provides a reference point. linux/arm omap4 pandaboard BenchmarkUint32Div7 10000000 298 ns/op BenchmarkUint32Div37 10000000 298 ns/op BenchmarkUint32Div123 10000000 298 ns/op BenchmarkUint32Div763 10000000 298 ns/op BenchmarkUint32Div1247 10000000 299 ns/op BenchmarkUint32Div9305 10000000 298 ns/op BenchmarkUint32Div13307 10000000 298 ns/op BenchmarkUint32Div52513 10000000 298 ns/op BenchmarkUint32Div60978747 10000000 298 ns/op BenchmarkUint32Div106956295 10000000 297 ns/op BenchmarkUint32Mod7 10000000 280 ns/op BenchmarkUint32Mod37 10000000 280 ns/op BenchmarkUint32Mod123 10000000 280 ns/op BenchmarkUint32Mod763 10000000 280 ns/op BenchmarkUint32Mod1247 10000000 280 ns/op BenchmarkUint32Mod9305 10000000 280 ns/op BenchmarkUint32Mod13307 10000000 280 ns/op BenchmarkUint32Mod52513 10000000 280 ns/op BenchmarkUint32Mod60978747 10000000 280 ns/op BenchmarkUint32Mod106956295 10000000 280 ns/op

Patch Set 1 #

Patch Set 2 : diff -r a621ac756347 https://code.google.com/p/go #

Patch Set 3 : diff -r a621ac756347 https://code.google.com/p/go #

Patch Set 4 : diff -r a621ac756347 https://code.google.com/p/go #

Patch Set 5 : diff -r 7ba52afb6a1b https://code.google.com/p/go #

Patch Set 6 : diff -r 7ba52afb6a1b https://code.google.com/p/go #

Total comments: 1

Patch Set 7 : diff -r 9da3902443ca https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
A src/pkg/runtime/vlop_arm_test.go View 1 2 3 4 5 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 7
dfc
Hello minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 6 months ago (2012-06-14 03:57:38 UTC) #1
rsc
Do you really mean runtime? It is true that package runtime's performance is affected by ...
10 years, 6 months ago (2012-06-14 04:00:40 UTC) #2
dfc
There are a few areas, mainly related to modulo that are still a problem for ...
10 years, 6 months ago (2012-06-14 04:03:53 UTC) #3
minux1
On 2012/06/14 04:00:40, rsc wrote: > Do you really mean runtime? It is true that ...
10 years, 5 months ago (2012-06-15 18:19:01 UTC) #4
dfc
<ping />
10 years, 5 months ago (2012-06-19 05:20:07 UTC) #5
rsc
LGTM in the description s/Arm/arm/ http://codereview.appspot.com/6258067/diff/7002/src/pkg/runtime/vlop_arm_test.go File src/pkg/runtime/vlop_arm_test.go (right): http://codereview.appspot.com/6258067/diff/7002/src/pkg/runtime/vlop_arm_test.go#newcode10 src/pkg/runtime/vlop_arm_test.go:10: // http://ridiculousfish.com/files/division_benchmarks.tar.gz FWIW ridiculousfish ...
10 years, 5 months ago (2012-06-25 21:37:53 UTC) #6
dfc
10 years, 5 months ago (2012-06-25 22:59:18 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=6f2a9ecdccf9 ***

runtime: add arm soft division and modulo benchmarks

arm soft div and mod performance plays an important part
in runtime performance.

The currently implementation is very stable, but we believe
we can best it. This benchmark provides a reference point.

linux/arm omap4 pandaboard

BenchmarkUint32Div7     10000000               298 ns/op
BenchmarkUint32Div37    10000000               298 ns/op
BenchmarkUint32Div123   10000000               298 ns/op
BenchmarkUint32Div763   10000000               298 ns/op
BenchmarkUint32Div1247  10000000               299 ns/op
BenchmarkUint32Div9305  10000000               298 ns/op
BenchmarkUint32Div13307 10000000               298 ns/op
BenchmarkUint32Div52513 10000000               298 ns/op
BenchmarkUint32Div60978747      10000000               298 ns/op
BenchmarkUint32Div106956295     10000000               297 ns/op
BenchmarkUint32Mod7     10000000               280 ns/op
BenchmarkUint32Mod37    10000000               280 ns/op
BenchmarkUint32Mod123   10000000               280 ns/op
BenchmarkUint32Mod763   10000000               280 ns/op
BenchmarkUint32Mod1247  10000000               280 ns/op
BenchmarkUint32Mod9305  10000000               280 ns/op
BenchmarkUint32Mod13307 10000000               280 ns/op
BenchmarkUint32Mod52513 10000000               280 ns/op
BenchmarkUint32Mod60978747      10000000               280 ns/op
BenchmarkUint32Mod106956295     10000000               280 ns/op

R=minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6258067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b