Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 6257072: state: add Machine.String() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by dfc
Modified:
9 years ago
Reviewers:
mp+108077
Visibility:
Public.

Description

state: add Machine.String() This proposal allows state.Machine to fulfil the Stringer interface so it is capable of printing itself in a way that is not dependant on it's internal represntation. https://code.launchpad.net/~dave-cheney/juju/go-state-machine-string/+merge/108077 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: add Machine.String() #

Patch Set 3 : state: add Machine.String() #

Total comments: 4

Patch Set 4 : state: add Machine.String() #

Patch Set 5 : state: add Machine.String() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M state/machine.go View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9
dfc
Please take a look.
9 years ago (2012-05-30 23:50:46 UTC) #1
dfc
Please take a look.
9 years ago (2012-05-30 23:53:21 UTC) #2
dfc
Please take a look.
9 years ago (2012-06-01 06:49:21 UTC) #3
fwereade
LGTM
9 years ago (2012-06-01 08:42:51 UTC) #4
niemeyer
LGTM assuming you're happy with the following suggestions. https://codereview.appspot.com/6257072/diff/6001/state/machine.go File state/machine.go (right): https://codereview.appspot.com/6257072/diff/6001/state/machine.go#newcode38 state/machine.go:38: return ...
9 years ago (2012-06-05 18:45:15 UTC) #5
dfc
Please take a look. https://codereview.appspot.com/6257072/diff/6001/state/machine.go File state/machine.go (right): https://codereview.appspot.com/6257072/diff/6001/state/machine.go#newcode38 state/machine.go:38: return fmt.Errorf("state: waiting for agent ...
9 years ago (2012-06-05 22:55:55 UTC) #6
niemeyer
You mentioned changes to the tests, but there's nothing in this branch about that. What's ...
9 years ago (2012-06-06 01:21:53 UTC) #7
dfc
It's actually the format of the error in WaitAgentAlive, which I've fixed so the test ...
9 years ago (2012-06-06 01:26:37 UTC) #8
dfc
9 years ago (2012-06-06 02:05:40 UTC) #9
*** Submitted:

state: add Machine.String()

This proposal allows state.Machine to fulfil the Stringer 
interface so it is capable of printing itself in a way that
is not dependant on it's internal represntation.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6257072
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b