Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2186)

Issue 6250068: cmd/jujud: strawman provisioning agent (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by dfc
Modified:
9 years ago
Reviewers:
mp+107714
Visibility:
Public.

Description

cmd/jujud: strawman provisioning agent This is a strawman provisioning agent proposal. Following Gustavo's suggestion, this revision does not include any functionality to respond to machines changes. https://code.launchpad.net/~dave-cheney/juju/go-provisioning-strawman/+merge/107714 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: strawman provisioning agent #

Total comments: 11

Patch Set 3 : cmd/jujud: strawman provisioning agent #

Patch Set 4 : cmd/jujud: strawman provisioning agent #

Total comments: 11

Patch Set 5 : cmd/jujud: strawman provisioning agent #

Patch Set 6 : cmd/jujud: strawman provisioning agent #

Patch Set 7 : cmd/jujud: strawman provisioning agent #

Patch Set 8 : cmd/jujud: strawman provisioning agent #

Patch Set 9 : cmd/jujud: strawman provisioning agent #

Total comments: 18

Patch Set 10 : cmd/jujud: strawman provisioning agent #

Patch Set 11 : cmd/jujud: strawman provisioning agent #

Patch Set 12 : cmd/jujud: strawman provisioning agent #

Total comments: 28

Patch Set 13 : cmd/jujud: strawman provisioning agent #

Patch Set 14 : cmd/jujud: strawman provisioning agent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -4 lines) Patch
A [revision details] View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/provisioning.go View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +114 lines, -3 lines 0 comments Download
M cmd/jujud/provisioning_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +84 lines, -1 line 0 comments Download

Messages

Total messages: 16
rog
this is looking nice. a few minor remarks below. https://codereview.appspot.com/6250068/diff/2001/cmd/jujud/provisioning.go File cmd/jujud/provisioning.go (right): https://codereview.appspot.com/6250068/diff/2001/cmd/jujud/provisioning.go#newcode17 cmd/jujud/provisioning.go:17: ...
9 years ago (2012-05-29 08:41:18 UTC) #1
dfc
Please take a look. https://codereview.appspot.com/6250068/diff/2001/cmd/jujud/provisioning.go File cmd/jujud/provisioning.go (right): https://codereview.appspot.com/6250068/diff/2001/cmd/jujud/provisioning.go#newcode17 cmd/jujud/provisioning.go:17: const PROVIDER_MACHINE_ID = "provider-machine-id" Beleted ...
9 years ago (2012-05-30 06:06:10 UTC) #2
niemeyer
This is going in a great direction Dave, and I'm excited to see this. At ...
9 years ago (2012-05-30 21:09:20 UTC) #3
niemeyer
Some more comments. Also, it just occurred to me that, as a very first step ...
9 years ago (2012-05-30 21:27:20 UTC) #4
dfc
Hi Gustavo, Thank you for your feedback. > At the same time, I'm concerned about ...
9 years ago (2012-05-30 21:52:30 UTC) #5
dfc
Please take a look. https://codereview.appspot.com/6250068/diff/6001/cmd/jujud/provisioning.go File cmd/jujud/provisioning.go (right): https://codereview.appspot.com/6250068/diff/6001/cmd/jujud/provisioning.go#newcode17 cmd/jujud/provisioning.go:17: const PROVIDER_MACHINE_ID = "provider-machine-id" On ...
9 years ago (2012-05-31 07:10:01 UTC) #6
dfc
Please take a look.
9 years ago (2012-05-31 07:26:21 UTC) #7
niemeyer
Thanks Dave. That is now looking like a great step forward that we can polish ...
9 years ago (2012-05-31 11:46:59 UTC) #8
dfc
Please take a look. https://codereview.appspot.com/6250068/diff/5004/cmd/jujud/provisioning.go File cmd/jujud/provisioning.go (right): https://codereview.appspot.com/6250068/diff/5004/cmd/jujud/provisioning.go#newcode37 cmd/jujud/provisioning.go:37: st, err := state.Open(&a.Conf.StateInfo) On ...
9 years ago (2012-05-31 22:40:03 UTC) #9
dfc
https://codereview.appspot.com/6250068/diff/5004/cmd/jujud/provisioning.go File cmd/jujud/provisioning.go (right): https://codereview.appspot.com/6250068/diff/5004/cmd/jujud/provisioning.go#newcode37 cmd/jujud/provisioning.go:37: st, err := state.Open(&a.Conf.StateInfo) > What happens if the ...
9 years ago (2012-06-01 01:58:27 UTC) #10
dfc
Please take a look.
9 years ago (2012-06-01 06:08:06 UTC) #11
dfc
Please take a look.
9 years ago (2012-06-03 22:55:48 UTC) #12
niemeyer
https://codereview.appspot.com/6250068/diff/5004/cmd/jujud/provisioning.go File cmd/jujud/provisioning.go (right): https://codereview.appspot.com/6250068/diff/5004/cmd/jujud/provisioning.go#newcode37 cmd/jujud/provisioning.go:37: st, err := state.Open(&a.Conf.StateInfo) On 2012/06/01 01:58:27, dfc wrote: ...
9 years ago (2012-06-04 23:22:23 UTC) #13
dfc
Please take a look. https://codereview.appspot.com/6250068/diff/16001/cmd/jujud/provisioning.go File cmd/jujud/provisioning.go (right): https://codereview.appspot.com/6250068/diff/16001/cmd/jujud/provisioning.go#newcode56 cmd/jujud/provisioning.go:56: // environChanges returns a channel ...
9 years ago (2012-06-05 07:59:54 UTC) #14
niemeyer
That last set of changes are awesome. LGTM.
9 years ago (2012-06-05 14:40:18 UTC) #15
dfc
9 years ago (2012-06-05 21:39:00 UTC) #16
*** Submitted:

cmd/jujud: strawman provisioning agent

This is a strawman provisioning agent proposal.

Following Gustavo's suggestion, this revision does not include
any functionality to respond to machines changes.

R=rog, niemeyer
CC=
https://codereview.appspot.com/6250068
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b