first step towards a deploy command

first step towards a deploy command

(all this does is parse *most* args; but IMO it's a chunk of useful
functionality nonetheless)

https://code.launchpad.net/~fwereade/juju/go-deploy-cmd-parsing/+merge/108375

(do not edit description out of merge proposal)

[fwereade, 2012-06-01 16:15:17]

Please take a look.

[niemeyer, 2012-06-05 21:12:52]

LGTM. A few suggestions, but feel free to submit:

https://codereview.appspot.com/6249075/diff/1/cmd/juju/cmd_test.go
File cmd/juju/cmd_test.go (right):

https://codereview.appspot.com/6249075/diff/1/cmd/juju/cmd_test.go#newcode193
cmd/juju/cmd_test.go:193: os.Setenv("JUJU_REPOSITORY", "/path/to/repo")
The test should preserve the environment as it found before the test started.
E.g.:

    defer os.Setenv("JUJU_REPOSITORY", os.Getenv("JUJU_REPOSITORY"))

The list of tests below look very appropriate for a table of tests as well.
Something along the lines of:

var deployTests = []struct{
    args []string
    cmd  *DeployCommand
}{
        {
            {"charm-name", "service-name"},
            &DeployCommand{
                    ...
            },
        }, {
            ...
        },
}

https://codereview.appspot.com/6249075/diff/1/cmd/juju/deploy.go
File cmd/juju/deploy.go (right):

https://codereview.appspot.com/6249075/diff/1/cmd/juju/deploy.go#newcode22
cmd/juju/deploy.go:22: "deploy", "<charm-name> [<service-name>]", "deploy a new
service", "",
We can avoid the dashes in these cases. <charm name> and <service name> read
quite nicely.

Also, can you please document the fact that <service name> defaults to <charm
name> if not provided?

[fwereade, 2012-06-06 09:54:28]

*** Submitted:

first step towards a deploy command

(all this does is parse *most* args; but IMO it's a chunk of useful
functionality nonetheless)

R=niemeyer
CC=
https://codereview.appspot.com/6249075

https://codereview.appspot.com/6249075/diff/1/cmd/juju/cmd_test.go
File cmd/juju/cmd_test.go (right):

https://codereview.appspot.com/6249075/diff/1/cmd/juju/cmd_test.go#newcode193
cmd/juju/cmd_test.go:193: os.Setenv("JUJU_REPOSITORY", "/path/to/repo")
On 2012/06/05 21:12:52, niemeyer wrote:
> The test should preserve the environment as it found before the test started.
> E.g.:
> 
>     defer os.Setenv("JUJU_REPOSITORY", os.Getenv("JUJU_REPOSITORY"))
> 
> The list of tests below look very appropriate for a table of tests as well.
> Something along the lines of:
> 
> var deployTests = []struct{
>     args []string
>     cmd  *DeployCommand
> }{
>         {
>             {"charm-name", "service-name"},
>             &DeployCommand{
>                     ...
>             },
>         }, {
>             ...
>         },
> }
> 
>         
>           

Done.

https://codereview.appspot.com/6249075/diff/1/cmd/juju/deploy.go
File cmd/juju/deploy.go (right):

https://codereview.appspot.com/6249075/diff/1/cmd/juju/deploy.go#newcode22
cmd/juju/deploy.go:22: "deploy", "<charm-name> [<service-name>]", "deploy a new
service", "",
On 2012/06/05 21:12:52, niemeyer wrote:
> We can avoid the dashes in these cases. <charm name> and <service name> read
> quite nicely.
> 
> Also, can you please document the fact that <service name> defaults to <charm
> name> if not provided?

Done.