Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

Issue 6249061: state: add machine.{Set,}InstanceId (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by dfc
Modified:
11 years, 10 months ago
Reviewers:
mp+107694
Visibility:
Public.

Description

state: add machine.{Set,}InstanceId Allow the state to set and retrieve the value of "provider-machine-id" stored in the /machines/machine-XXX node. The PA needs this initially to store the instance id returned from environ.StartInstance. https://code.launchpad.net/~dave-cheney/juju/go-machine-config/+merge/107694 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : state: add machine.Config() #

Patch Set 3 : state: add machine.{Set,}InstanceId #

Patch Set 4 : state: add machine.{Set,}InstanceId #

Patch Set 5 : state: add machine.{Set,}InstanceId #

Total comments: 1

Patch Set 6 : state: add machine.{Set,}InstanceId #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
A [revision details] View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M state/export_test.go View 1 chunk +5 lines, -0 lines 0 comments Download
M state/machine.go View 1 2 3 4 5 2 chunks +30 lines, -0 lines 0 comments Download
M state/state_test.go View 1 2 3 4 5 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 10
dfc
Please take a look.
11 years, 10 months ago (2012-05-28 23:18:22 UTC) #1
fwereade
https://codereview.appspot.com/6249061/diff/1/state/machine.go File state/machine.go (right): https://codereview.appspot.com/6249061/diff/1/state/machine.go#newcode50 state/machine.go:50: func (m *Machine) Config() (*ConfigNode, error) { Not comfortable ...
11 years, 10 months ago (2012-05-29 07:15:55 UTC) #2
niemeyer
https://codereview.appspot.com/6249061/diff/1/state/machine.go File state/machine.go (right): https://codereview.appspot.com/6249061/diff/1/state/machine.go#newcode50 state/machine.go:50: func (m *Machine) Config() (*ConfigNode, error) { On 2012/05/29 ...
11 years, 10 months ago (2012-05-29 18:03:16 UTC) #3
dfc
Please take a look. https://codereview.appspot.com/6249061/diff/1/state/state.go File state/state.go (right): https://codereview.appspot.com/6249061/diff/1/state/state.go#newcode20 state/state.go:20: zkEmptyConfig = "" On 2012/05/29 ...
11 years, 10 months ago (2012-05-29 23:12:32 UTC) #4
dfc
Please take a look.
11 years, 10 months ago (2012-05-29 23:14:48 UTC) #5
dfc
Please take a look.
11 years, 10 months ago (2012-05-29 23:31:30 UTC) #6
dfc
Please take a look.
11 years, 10 months ago (2012-05-29 23:38:09 UTC) #7
niemeyer
LGTM with just a detail in the error message. Btw, coderevirew is pretty buggy from ...
11 years, 10 months ago (2012-05-30 00:18:58 UTC) #8
dfc
will fix before submitting, thanks. Sent from my iPad On 30/05/2012, at 10:18, n13m3y3r@gmail.com wrote: ...
11 years, 10 months ago (2012-05-30 00:26:55 UTC) #9
dfc
11 years, 10 months ago (2012-05-30 01:14:07 UTC) #10
*** Submitted:

state: add machine.{Set,}InstanceId

Allow the state to set and retrieve the value of "provider-machine-id" 
stored in the /machines/machine-XXX node. The PA needs this initially to 
store the instance id returned from environ.StartInstance.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6249061
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b