Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1678)

Issue 6249050: Change patheffect to take a (new) StrokeRec object, which encapsulates the fill (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by reed1
Modified:
12 years, 6 months ago
Reviewers:
bungeman
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Change patheffect to take a (new) StrokeRec object, which encapsulates the fill or stroke parameters for a path. Today, the patheffect only sees if the caller was going to stroke or fill, and if stroke, it just sees the width. With this change, the effect can see all of the related parameters (e.g. cap/join/miter). No other change is intended at this time. After this change, I hope to use this additional data to allow SkDashPathEffect to, at times, apply the stroke as part of its effect, which may be much more efficient than first dashing, and then reading that and stroking it. Most of these files changed just because of the new parameter to filterPath. The key changes are in SkPathEffect.[h,cpp], SkPaint.cpp and SkScalerContext.cpp Committed: https://code.google.com/p/skia/source/detail?r=4046

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -213 lines) Patch
M bench/DashBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkPathEffect.h View 1 2 4 chunks +94 lines, -12 lines 0 comments Download
M include/effects/Sk1DPathEffect.h View 2 chunks +2 lines, -4 lines 0 comments Download
M include/effects/Sk2DPathEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkCornerPathEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkDashPathEffect.h View 1 chunk +1 line, -3 lines 0 comments Download
M include/effects/SkDiscretePathEffect.h View 1 chunk +1 line, -3 lines 0 comments Download
M samplecode/ClockFaceView.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M samplecode/SampleSlides.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M samplecode/SampleTextEffects.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkPaint.cpp View 1 1 chunk +15 lines, -49 lines 0 comments Download
M src/core/SkPathEffect.cpp View 1 3 chunks +77 lines, -98 lines 0 comments Download
M src/core/SkScalerContext.cpp View 1 1 chunk +18 lines, -14 lines 0 comments Download
M src/core/SkStroke.cpp View 1 chunk +27 lines, -1 line 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/effects/Sk2DPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkCornerPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkDiscretePathEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2
reed1
12 years, 6 months ago (2012-05-24 18:19:46 UTC) #1
bungeman
12 years, 6 months ago (2012-05-24 20:05:59 UTC) #2
On 2012/05/24 18:19:46, reed1 wrote:

So long as it doesn't break anything, LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b