samplecode/ClockFaceView.cpp - Issue 6249050: Change patheffect to take a (new) StrokeRec object, which encapsulates the fill

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: samplecode/ClockFaceView.cpp

Issue 6249050: Change patheffect to take a (new) StrokeRec object, which encapsulates the fill (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 12 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samplecode/ClockFaceView.cpp

===================================================================

--- samplecode/ClockFaceView.cpp (revision 4044)

+++ samplecode/ClockFaceView.cpp (working copy)

@@ -108,7 +108,7 @@

class InverseFillPE : public SkPathEffect {

public:

InverseFillPE() {}

- virtual bool filterPath(SkPath* dst, const SkPath& src, SkScalar* width) {

+ virtual bool filterPath(SkPath* dst, const SkPath& src, SkStrokeRec*) SK_OVERRIDE {

*dst = src;

dst->setFillType(SkPath::kInverseWinding_FillType);

return true;

@@ -197,10 +197,10 @@

SkTDArray<SkPoint> pts;

SkPathEffect* pe = makepe(0, &pts);

- SkScalar width = -1;

+ SkStrokeRec rec(SkStrokeRec::kFill_InitStyle);

SkPath path, dstPath;

orig.getTextPath("9", 1, 0, 0, &path);

- pe->filterPath(&dstPath, path, &width);

+ pe->filterPath(&dstPath, path, &rec);

SkPaint p;

p.setAntiAlias(true);

« no previous file with comments | « include/effects/SkDiscretePathEffect.h ('k') | samplecode/SampleAll.cpp » ('j') | no next file with comments »