Issue 6247059: state: Renamed zk* to top* in topology.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6247059: state: Renamed zk* to top* in topology. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by TheMue

Modified:
11 years, 10 months ago

Reviewers:
mp+107947

Visibility:
Public.

Description

state: Renamed zk* to top* in topology. This way the entity names in topology.go are more technology independend. So far the comments contain references to ZooKeeper. In the moment we change to an own API hiding the technology the comments should change too. https://code.launchpad.net/~themue/juju/go-state-topology-zk-to-top/+merge/107947 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: Renamed zk* to top* in topology. #

Patch Set 3 : state: Renamed zk* to top* in topology. #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -124 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/internal_test.go	View	1	11 chunks	+86 lines, -86 lines	0 comments	Download
M	state/topology.go	View	1	11 chunks	+38 lines, -38 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

LGTM if we rename it to "topo" rather than "top", as the latter is an ...

11 years, 11 months ago (2012-05-30 22:30:23 UTC) #2

TheMue

11 years, 11 months ago (2012-05-31 11:57:54 UTC) #5

*** Submitted:

state: Renamed zk* to top* in topology.

This way the entity names in topology.go are more
technology independend. So far the comments contain
references to ZooKeeper. In the moment we change to
an own API hiding the technology the comments should
change too.

R=niemeyer
CC=
https://codereview.appspot.com/6247059

Expand All Messages | Collapse All Messages