Issue 6245080: FD-MT LTE scheduler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6245080: FD-MT LTE scheduler

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by Dizhi.Zhou

Modified:
11 years, 11 months ago

Reviewers:
Marco Miozzo

CC:
Nicola Baldo

Visibility:
Public.

More Reviews

Description

FD-MT LTE scheduler

Patch Set 1 #

Total comments: 3

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4351 lines, -75 lines)			Patch
M	src/lte/doc/source/lte-design.rst	View	14 chunks	+47 lines, -27 lines	1 comment	Download
M	src/lte/doc/source/lte-references.rst	View	2 chunks	+34 lines, -32 lines	0 comments	Download
M	src/lte/doc/source/lte-testing.rst	View	7 chunks	+49 lines, -16 lines	0 comments	Download
A	src/lte/model/fdmt-ff-mac-scheduler.h	View	1 chunk	+227 lines, -0 lines	1 comment	Download
A	src/lte/model/fdmt-ff-mac-scheduler.cc	View	1 chunk	+1215 lines, -0 lines	1 comment	Download
A	src/lte/test/lte-test-fdmt-ff-mac-scheduler.h	View	1 chunk	+67 lines, -0 lines	0 comments	Download
A	src/lte/test/lte-test-fdmt-ff-mac-scheduler.cc	View	1 chunk	+347 lines, -0 lines	0 comments	Download
M	src/lte/wscript	View	3 chunks	+23 lines, -0 lines	0 comments	Download
A	upload.py	View	1 chunk	+2342 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Marco Miozzo

11 years, 11 months ago (2012-06-01 14:57:26 UTC) #1

A few minor comments for fixing what discussed in the skype.

http://codereview.appspot.com/6245080/diff/1/src/lte/doc/source/lte-design.rst
File src/lte/doc/source/lte-design.rst (right):

http://codereview.appspot.com/6245080/diff/1/src/lte/doc/source/lte-design.rs...
src/lte/doc/source/lte-design.rst:87: in [Ofcom2.6GHz]_ and [RealWireless]_. The
calculation of interference should
all the changes related to the new branch can be solved as explained in the
skype (hg update/merge)

http://codereview.appspot.com/6245080/diff/1/src/lte/model/fdmt-ff-mac-schedu...
File src/lte/model/fdmt-ff-mac-scheduler.cc (right):

http://codereview.appspot.com/6245080/diff/1/src/lte/model/fdmt-ff-mac-schedu...
src/lte/model/fdmt-ff-mac-scheduler.cc:310: std::map <uint16_t,
fdmtsFlowPerf_t>::iterator it;
As in header file, remove dead code.

http://codereview.appspot.com/6245080/diff/1/src/lte/model/fdmt-ff-mac-schedu...
File src/lte/model/fdmt-ff-mac-scheduler.h (right):

http://codereview.appspot.com/6245080/diff/1/src/lte/model/fdmt-ff-mac-schedu...
src/lte/model/fdmt-ff-mac-scheduler.h:44: // TBD
As suggested in the skype, it is common practice to remove dead code.

Expand All Messages | Collapse All Messages