Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(835)

Issue 6245070: get rid of Mac visibility warnings

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by caryclark1
Modified:
11 years, 11 months ago
Base URL:
http://skia.googlecode.com/svn/trunk/gyp/
Visibility:
Public.

Description

Command line builds and xcode projects on the Mac generate hundreds of warnings complaining about mismatched visibility between files. While there's no way to suppress the warnings, the visibility can be made the same across the board.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M common_conditions.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
epoger
Rob, is http://code.google.com/p/skia/issues/detail?id=555 ('"bad codegen, pointer diff in SkRefCnt::SkRefCnt()" when building "tests" app on Mac') ...
11 years, 11 months ago (2012-05-30 19:46:31 UTC) #1
robertphillips
The patch we applied in http://codereview.appspot.com/5992048/ got the Mac port compiling for me. I hope ...
11 years, 11 months ago (2012-05-30 19:55:05 UTC) #2
robertphillips
So LGTM.
11 years, 11 months ago (2012-05-30 20:03:38 UTC) #3
epoger
11 years, 11 months ago (2012-05-30 20:08:23 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b