state: fix watcher semantics and tests.

state: fix watcher semantics and tests.

The watchers are now all documented as returning the
initial state as the first event on the channel,
(a change actually made a little while ago)
and the tests now reflect this.

https://code.launchpad.net/~rogpeppe/juju/go-state-fix-watcher-tests/+merge/107380

(do not edit description out of merge proposal)

[rog, 2012-05-25 13:44:02]

Please take a look.

[rog, 2012-05-25 13:46:29]

Please take a look.

[TheMue, 2012-05-25 13:57:24]

LGTM

On 2012/05/25 13:46:29, rog wrote:
> Please take a look.

[niemeyer, 2012-05-25 19:42:38]

Nice fix, LGTM.

Please just consider the following before merging:

https://codereview.appspot.com/6245053/diff/12/state/watcher.go
File state/watcher.go (right):

https://codereview.appspot.com/6245053/diff/12/state/watcher.go#newcode34
state/watcher.go:34: // The first event on the channel will always be sent
immediately
// The first event on the channel represents the current state.

Isn't that what actually happens!? It can'be sent immediately since the first
state is *also* obtained from the remote host.

Same for all the other comments.

[rog, 2012-05-25 22:42:14]

Sorry, I don't understand that...
On May 25, 2012 8:42 PM, <n13m3y3r@gmail.com> wrote:
>
> Nice fix, LGTM.
>
> Please just consider the following before merging:
>
>
> https://codereview.appspot.com/6245053/diff/12/state/watcher.go
> File state/watcher.go (right):
>
> https://codereview.appspot.com/6245053/diff/12/state/watcher.go#newcode34
> state/watcher.go:34: // The first event on the channel will always be
> sent immediately
> // The first event on the channel represents the current state.
>
> Isn't that what actually happens!? It can'be sent immediately since the
> first state is *also* obtained from the remote host.
>
> Same for all the other comments.
>
> https://codereview.appspot.com/6245053/

[rog, 2012-05-28 07:25:34]

*** Submitted:

state: fix watcher semantics and tests.

The watchers are now all documented as returning the
initial state as the first event on the channel,
(a change actually made a little while ago)
and the tests now reflect this.

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6245053