Issue 6243067: Add State method to juju.Conn

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6243067: Add State method to juju.Conn

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by fwereade

Modified:
11 years, 11 months ago

Reviewers:
mp+107806

Visibility:
Public.

Description

Add State method to juju.Conn https://code.launchpad.net/~fwereade/juju/go-conn-state/+merge/107806 Requires: https://code.launchpad.net/~fwereade/juju/go-dummy-environ-state/+merge/107795 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add State method to juju.Conn #

Patch Set 3 : Add State method to juju.Conn #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -10 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/conn.go	View	1 2	4 chunks	+23 lines, -2 lines	0 comments	Download
M	juju/conn_test.go	View		2 chunks	+26 lines, -8 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

rog

LGTM modulo the thought below. https://codereview.appspot.com/6243067/diff/1/juju/conn.go File juju/conn.go (right): https://codereview.appspot.com/6243067/diff/1/juju/conn.go#newcode47 juju/conn.go:47: if c.state == nil ...

11 years, 11 months ago (2012-05-29 15:39:50 UTC) #2

niemeyer

LGTM too https://codereview.appspot.com/6243067/diff/1/juju/conn.go File juju/conn.go (right): https://codereview.appspot.com/6243067/diff/1/juju/conn.go#newcode47 juju/conn.go:47: if c.state == nil { On 2012/05/29 ...

11 years, 11 months ago (2012-05-29 18:10:39 UTC) #3

niemeyer

On 2012/05/30 10:31:52, fwereade wrote: > Please take a look. Nothing has changed..?

11 years, 11 months ago (2012-05-30 10:46:54 UTC) #5

fwereade

On 2012/05/30 10:46:54, niemeyer wrote: > On 2012/05/30 10:31:52, fwereade wrote: > > Please take ...

11 years, 11 months ago (2012-05-30 11:07:23 UTC) #6

fwereade

11 years, 11 months ago (2012-05-31 07:45:38 UTC) #7

*** Submitted:

Add State method to juju.Conn

R=rog, niemeyer
CC=
https://codereview.appspot.com/6243067

https://codereview.appspot.com/6243067/diff/1/juju/conn.go
File juju/conn.go (right):

https://codereview.appspot.com/6243067/diff/1/juju/conn.go#newcode47
juju/conn.go:47: if c.state == nil {
On 2012/05/29 18:10:39, niemeyer wrote:
> On 2012/05/29 15:39:50, rog wrote:
> > guard with a mutex?
> > we take care to make Environ thread-safe, so Conn should probably be safe
too.
> 
> +1

Done.

Expand All Messages | Collapse All Messages