Issue 6243054: Fixed a signature change I somehow missed :/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6243054: Fixed a signature change I somehow missed :/

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by fwereade

Modified:
11 years, 11 months ago

Reviewers:
mp+107352

Visibility:
Public.

Description

Fixed a signature change I somehow missed :/ https://code.launchpad.net/~fwereade/juju/go-trivial-addcharm-test-fix/+merge/107352 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixed a signature change I somehow missed :/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/jujuc/server/util_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2012/05/25 09:26:17, fwereade wrote: > Please take a look. +1

11 years, 11 months ago (2012-05-25 09:27:11 UTC) #2

fwereade

11 years, 11 months ago (2012-05-25 12:52:02 UTC) #3

*** Submitted:

Fixed a signature change I somehow missed :/

R=dfc
CC=
https://codereview.appspot.com/6243054

Expand All Messages | Collapse All Messages