Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3442)

Issue 6242059: disable journaling to speed up tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by fwereade
Modified:
11 years, 11 months ago
Reviewers:
mp+107389
Visibility:
Public.

Description

disable journaling to speed up tests https://code.launchpad.net/~fwereade/juju/go-store-mgo-test-timeout/+merge/107389 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Increase dial timeout to allow tests to succeed consistently #

Patch Set 3 : Increase dial timeout to allow tests to succeed consistently #

Patch Set 4 : disable journaling to speed up tests #

Patch Set 5 : disable journaling to speed up tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M store/mgo_test.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11
fwereade
Please take a look.
11 years, 11 months ago (2012-05-25 14:03:23 UTC) #1
niemeyer
I don't think we should change this. If a single function is taking *10 seconds* ...
11 years, 11 months ago (2012-05-25 16:46:16 UTC) #2
niemeyer
I wish there was a Needs Info status. For the lack of that I'm moving ...
11 years, 11 months ago (2012-05-25 17:50:26 UTC) #3
fwereade
On 2012/05/25 17:50:26, niemeyer wrote: > I wish there was a Needs Info status. For ...
11 years, 11 months ago (2012-05-28 08:51:26 UTC) #4
fwereade
On 2012/05/28 08:51:26, fwereade wrote:more usually I see "OOPS: 1 > passed, 2 FIXTURE-PANICKED, 25 ...
11 years, 11 months ago (2012-05-28 08:52:54 UTC) #5
fwereade
Please take a look.
11 years, 11 months ago (2012-05-28 08:54:21 UTC) #6
niemeyer
On 2012/05/28 08:51:26, fwereade wrote: > There's really only so much info I can give... ...
11 years, 11 months ago (2012-05-28 10:24:54 UTC) #7
fwereade
Please take a look.
11 years, 11 months ago (2012-05-28 10:25:19 UTC) #8
fwereade
Please take a look.
11 years, 11 months ago (2012-05-28 12:44:14 UTC) #9
niemeyer
LGTM
11 years, 11 months ago (2012-05-28 12:46:46 UTC) #10
fwereade
11 years, 11 months ago (2012-05-28 13:06:43 UTC) #11
*** Submitted:

disable journaling to speed up tests

R=niemeyer
CC=
https://codereview.appspot.com/6242059
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b