Issue 62390043: Fix the juju-run on machines with no units.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 62390043: Fix the juju-run on machines with no units.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by thumper

Modified:
10 years, 2 months ago

Reviewers:
mp+206050, wallyworld

Visibility:
Public.

Description

Fix the juju-run on machines with no units. This branch also adds an upgrade step to make sure that existing environments also get the goodness. https://code.launchpad.net/~thumper/juju-core/juju-run-on-machine-with-no-units/+merge/206050 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix the juju-run on machines with no units. #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+224 lines, -7 lines)			Patch
[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
environs/cloudinit/cloudinit.go	View		1 chunk	+9 lines, -1 line	0 comments	Download
environs/cloudinit/cloudinit_test.go	View		2 chunks	+4 lines, -2 lines	0 comments	Download
upgrades/export_test.go	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
upgrades/steps118.go	View	1	1 chunk	+44 lines, -2 lines	0 comments	Download
upgrades/steps118_test.go	View	1	1 chunk	+117 lines, -0 lines	0 comments	Download
upgrades/upgrade.go	View	1	6 chunks	+36 lines, -1 line	0 comments	Download
upgrades/upgrade_test.go	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

wallyworld

10 years, 2 months ago (2014-02-13 03:48:25 UTC) #3

LGTM. We need one more test to ensure the upgrade operation is registered
correctly but I'll add that in my next lot of work as I have to do it anyway.

https://codereview.appspot.com/62390043/diff/1/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/62390043/diff/1/environs/cloudinit/cloudinit.g...
environs/cloudinit/cloudinit.go:282: 
part of me wishes that "locks" were a const somewhere

Expand All Messages | Collapse All Messages