When running on windows use current credentials for SPUserProfile Adaptor

When running on windows use current credentials for SPUserProfile Adaptor

[Tanmay Vartak, 2014-02-12 19:27:15]

On 2014/02/12 19:24:14, Tanmay Vartak wrote:

Fix for b/12725168 [User Profile Adaptor] Running adaptor from windows machine
expects to have admin l credentials in adaptor config properties file

My first TDD where I wrote test case first and fix later :) . Writing test case
takes more time :)

[ejona, 2014-02-12 22:30:34]

TDD FTW!

https://codereview.appspot.com/62330043/diff/1/test/com/google/enterprise/ada...
File
test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java
(right):

https://codereview.appspot.com/62330043/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java:98:
boolean onWindows = System.getProperty("os.name").contains("Windows");
Use assumeTrue(System.getProperty("os.name").contains("Windows")). Assume
prevents the test from running if a pre-condition isn't satisfied (like running
on Windows).

https://codereview.appspot.com/62330043/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java:100:
Config adaptorConfig = new Config();
You don't really need to, but if you want, you can call adaptorConfig.validate()
and it will throw an exception if anything wasn't specified. You will need to
set gsa.hostname for that to work though.

https://codereview.appspot.com/62330043/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java:106:
MockUserProfileServiceFactoryImpl serviceFactory =
What is the rest of this test for?

[ejona, 2014-02-12 22:31:09]

https://codereview.appspot.com/62330043/diff/1/test/com/google/enterprise/ada...
File
test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java
(right):

https://codereview.appspot.com/62330043/diff/1/test/com/google/enterprise/ada...
test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java:106:
MockUserProfileServiceFactoryImpl serviceFactory =
On 2014/02/12 22:30:35, ejona wrote:
> What is the rest of this test for?

nm. I figured it out. That is to make sure that we don't break forms auth.

[ejona, 2014-02-14 23:23:26]

LGTM

[Tanmay Vartak, 2014-02-15 00:25:19]

On 2014/02/14 23:23:26, ejona wrote:
> LGTM

Code Commit :
https://code.google.com/p/plexi/source/detail?r=579e76cbdd5019faeb4f55f0df8fa...