Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2191)

Issue 6230045: Fix V8 lockup on debugger disconnect

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by catid
Modified:
9 years, 9 months ago
Reviewers:
fschneider, yangguo
CC:
erik.corry, mikhail.naganov
Base URL:
https://github.com/v8/v8.git@master
Visibility:
Public.

Description

Inline CloseSession() and remove call to Join() to avoid joining ourselves on disconnect. This fixes a lockup when the USB cable is disconnected from a cellphone, etc.. BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/debug-agent.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5
catid
This is a bugfix for an issue we were having with V8. Hope it helps ...
11 years, 11 months ago (2012-05-22 18:09:24 UTC) #1
yangguo
On 2012/05/22 18:09:24, catid wrote: > This is a bugfix for an issue we were ...
11 years, 11 months ago (2012-05-23 07:59:16 UTC) #2
catid
Signed it -Chris On Wed, May 23, 2012 at 12:59 AM, <yangguo@chromium.org> wrote: > On ...
11 years, 11 months ago (2012-05-23 15:26:33 UTC) #3
yangguo
On 2012/05/23 15:26:33, catid wrote: > Signed it > -Chris > > On Wed, May ...
11 years, 10 months ago (2012-06-04 08:58:11 UTC) #4
yangguo
11 years, 10 months ago (2012-06-04 09:01:11 UTC) #5
On 2012/06/04 08:58:11, yangguo wrote:
> On 2012/05/23 15:26:33, catid wrote:
> > Signed it
> > -Chris
> > 
> > On Wed, May 23, 2012 at 12:59 AM, <mailto:yangguo@chromium.org> wrote:
> > 
> > > On 2012/05/22 18:09:24, catid wrote:
> > >
> > >> This is a bugfix for an issue we were having with V8.  Hope it helps
> > >>
> > > other
> > >
> > >> people too!
> > >>
> > >
> > >  Best,
> > >> Chris
> > >>
> > >
> > > Thank you for your contribution! Please sign the CLA (electronically) so
> > > we can use your code:
> > >
> >
>
http://code.google.com/legal/**individual-cla-v1.0.html%253Chttp://code.googl...>
> > >
> > >
> >
>
https://codereview.appspot.**com/6230045/%253Chttps://codereview.appspot.com/...>
> > >
> 
> LGTM. Landing.

I moved this CL to the correct rietveld:
http://codereview.chromium.org/10479009/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b