code review 62270043: crypto/sha1: always test the portable block function too

crypto/sha1: always test the portable block function too

So it doesn't bitrot.

[bradfitz, 2014-02-12 18:57:40]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[agl1, 2014-02-12 19:06:47]

This is certainly lightweight. The name "genblock" tripped me up however because
I read "generate block". Maybe "blockGeneric"?

[bradfitz, 2014-02-12 19:16:28]

Hello golang-codereviews@googlegroups.com, agl@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[bradfitz, 2014-02-12 19:16:32]

Done. PTAL.



On Wed, Feb 12, 2014 at 11:06 AM, <agl@golang.org> wrote:

> This is certainly lightweight. The name "genblock" tripped me up however
> because I read "generate block". Maybe "blockGeneric"?
>
> https://codereview.appspot.com/62270043/
>

[bradfitz, 2014-02-12 19:17:17]

Hello golang-codereviews@googlegroups.com, agl@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[agl1, 2014-02-12 19:20:36]

Others might want to chime in but LGTM.

[bradfitz, 2014-02-12 19:27:39]

*** Submitted as https://code.google.com/p/go/source/detail?r=6ad0d0d6147c ***

crypto/sha1: always test the portable block function too

So it doesn't bitrot.

LGTM=agl
R=golang-codereviews, agl
CC=golang-codereviews
https://codereview.appspot.com/62270043

[gobot, 2014-02-12 21:32:05]

This CL appears to have broken the windows-386-ec2 builder.