Issue 6221058: environs/ec2: fix amazon tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6221058: environs/ec2: fix amazon tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rog

Modified:
11 years, 11 months ago

Reviewers:
mp+106795

Visibility:
Public.

Description

environs/ec2: fix amazon tests Actually it doesn't quite fix them, but we need to wait for S3 signed URLs first. https://code.launchpad.net/~rogpeppe/juju/go-ec2-fix-amazon-tests/+merge/106795 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: fix amazon tests #

Total comments: 1

Patch Set 3 : environs/ec2: fix amazon tests #

Patch Set 4 : environs/ec2: fix amazon tests #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -8 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/live_test.go	View	1 2 3	3 chunks	+13 lines, -5 lines	0 comments	Download
M	environs/jujutest/tests.go	View		3 chunks	+25 lines, -2 lines	0 comments	Download
M	state/ssh.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

https://codereview.appspot.com/6221058/diff/2001/environs/ec2/storage.go File environs/ec2/storage.go (right): https://codereview.appspot.com/6221058/diff/2001/environs/ec2/storage.go#newcode39 environs/ec2/storage.go:39: err := s.bucket.PutReader(file, r, length, "binary/octet-stream", s3.PublicRead) Whaaaaaaat!? No ...

11 years, 11 months ago (2012-05-22 13:36:22 UTC) #2

niemeyer

LGTM assuming reduced timeouts and increased N as discussed online.

11 years, 11 months ago (2012-05-22 16:53:05 UTC) #4

rog

11 years, 11 months ago (2012-05-22 16:57:27 UTC) #5

*** Submitted:

environs/ec2: fix amazon tests

Actually it doesn't quite fix them, but we need to
wait for S3 signed URLs first.

R=niemeyer
CC=
https://codereview.appspot.com/6221058

Expand All Messages | Collapse All Messages