I use Doxygen instead of gtk-doc since gtk-doc doesn't suppport C++.
lgtm, with some comments https://codereview.appspot.com/6211062/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/6211062/diff/1/configure.ac#newcode170 configure.ac:170: [enable_db_android=$enableval], nit https://codereview.appspot.com/6211062/diff/1/configure.ac#newcode179 configure.ac:179: [enable_db_open_phrase=$enableval], They are arguments of AC_ARG_ENABLE? Should be align with AS_HELP_STRING? https://codereview.appspot.com/6211062/diff/1/docs/Makefile.am File docs/Makefile.am (right): https://codereview.appspot.com/6211062/diff/1/docs/Makefile.am#newcode1 docs/Makefile.am:1: if HAVE_DOXYGEN License header? https://codereview.appspot.com/6211062/diff/1/src/PyZyConfig.h File src/PyZyConfig.h (right): https://codereview.appspot.com/6211062/diff/1/src/PyZyConfig.h#newcode5 src/PyZyConfig.h:5: * Copyright (c) 2008-2010 Peng Huang <shawn.p.huang@gmail.com> Add new copyright line? https://codereview.appspot.com/6211062/diff/1/src/PyZyConfig.h#newcode22 src/PyZyConfig.h:22: /** This interface is not public. Do you know how to hide it in doc? https://codereview.appspot.com/6211062/diff/1/src/PyZyConst.h File src/PyZyConst.h (right): https://codereview.appspot.com/6211062/diff/1/src/PyZyConst.h#newcode40 src/PyZyConst.h:40: #define PINYIN_CORRECT_ON_TO_ONG (1U << 8) A new line https://codereview.appspot.com/6211062/diff/1/src/PyZyConst.h#newcode72 src/PyZyConst.h:72: #define PINYIN_FUZZY_UANG_UAN PINYIN_FUZZY_ANG_AN dito
Thanks! Submitting... https://codereview.appspot.com/6211062/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/6211062/diff/1/configure.ac#newcode170 configure.ac:170: [enable_db_android=$enableval], On 2012/05/18 14:54:57, Peng wrote: > nit Done. https://codereview.appspot.com/6211062/diff/1/configure.ac#newcode179 configure.ac:179: [enable_db_open_phrase=$enableval], On 2012/05/18 14:54:57, Peng wrote: > They are arguments of AC_ARG_ENABLE? Should be align with AS_HELP_STRING? Done. https://codereview.appspot.com/6211062/diff/1/docs/Makefile.am File docs/Makefile.am (right): https://codereview.appspot.com/6211062/diff/1/docs/Makefile.am#newcode1 docs/Makefile.am:1: if HAVE_DOXYGEN On 2012/05/18 14:54:57, Peng wrote: > License header? Done. https://codereview.appspot.com/6211062/diff/1/src/PyZyConfig.h File src/PyZyConfig.h (right): https://codereview.appspot.com/6211062/diff/1/src/PyZyConfig.h#newcode22 src/PyZyConfig.h:22: /** Sorry, I have forgotten to remove this comment. Removed. https://codereview.appspot.com/6211062/diff/1/src/PyZyConst.h File src/PyZyConst.h (right): https://codereview.appspot.com/6211062/diff/1/src/PyZyConst.h#newcode40 src/PyZyConst.h:40: #define PINYIN_CORRECT_ON_TO_ONG (1U << 8) On 2012/05/18 14:54:57, Peng wrote: > A new line Done. https://codereview.appspot.com/6211062/diff/1/src/PyZyConst.h#newcode72 src/PyZyConst.h:72: #define PINYIN_FUZZY_UANG_UAN PINYIN_FUZZY_ANG_AN On 2012/05/18 14:54:57, Peng wrote: > dito Done.