Issue 6211062: Writes a API document using doxygen.

Issue 6211062: Writes a API document using doxygen. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by hsumita1

Modified:
11 years, 11 months ago

Reviewers:
shawn.p.huang, Peng Huang, penghuang

Base URL:
git@github.com:pyzy/pyzy.git@master

Visibility:
Public.

More Reviews

Description

Writes a API document using doxygen. BUG=None TEST=Manual

Patch Set 2 : #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2017 lines, -23 lines)			Patch
M	Makefile.am	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	configure.ac	View	1	2 chunks	+13 lines, -4 lines	0 comments	Download
A	docs/.gitignore	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	docs/Doxyfile.in	View		1 chunk	+1554 lines, -0 lines	0 comments	Download
A	docs/Makefile.am	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
M	src/PyZyConfig.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/PyZyConst.h	View	1	4 chunks	+20 lines, -3 lines	0 comments	Download
M	src/PyZyInputContext.h	View		2 chunks	+341 lines, -14 lines	0 comments	Download
M	src/PyZyVariant.h	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hsumita1

I use Doxygen instead of gtk-doc since gtk-doc doesn't suppport C++.

11 years, 11 months ago (2012-05-18 05:50:24 UTC) #1

Peng

lgtm, with some comments https://codereview.appspot.com/6211062/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/6211062/diff/1/configure.ac#newcode170 configure.ac:170: [enable_db_android=$enableval], nit https://codereview.appspot.com/6211062/diff/1/configure.ac#newcode179 configure.ac:179: [enable_db_open_phrase=$enableval], ...

11 years, 11 months ago (2012-05-18 14:54:57 UTC) #2

hsumita1

11 years, 11 months ago (2012-05-21 03:06:29 UTC) #3

Thanks!

Submitting...

https://codereview.appspot.com/6211062/diff/1/configure.ac
File configure.ac (right):

https://codereview.appspot.com/6211062/diff/1/configure.ac#newcode170
configure.ac:170: [enable_db_android=$enableval],
On 2012/05/18 14:54:57, Peng wrote:
> nit

Done.

https://codereview.appspot.com/6211062/diff/1/configure.ac#newcode179
configure.ac:179: [enable_db_open_phrase=$enableval],
On 2012/05/18 14:54:57, Peng wrote:
> They are arguments of AC_ARG_ENABLE? Should be align with AS_HELP_STRING? 

Done.

https://codereview.appspot.com/6211062/diff/1/docs/Makefile.am
File docs/Makefile.am (right):

https://codereview.appspot.com/6211062/diff/1/docs/Makefile.am#newcode1
docs/Makefile.am:1: if HAVE_DOXYGEN
On 2012/05/18 14:54:57, Peng wrote:
> License header?

Done.

https://codereview.appspot.com/6211062/diff/1/src/PyZyConfig.h
File src/PyZyConfig.h (right):

https://codereview.appspot.com/6211062/diff/1/src/PyZyConfig.h#newcode22
src/PyZyConfig.h:22: /**
Sorry, I have forgotten to remove this comment.
Removed.

https://codereview.appspot.com/6211062/diff/1/src/PyZyConst.h
File src/PyZyConst.h (right):

https://codereview.appspot.com/6211062/diff/1/src/PyZyConst.h#newcode40
src/PyZyConst.h:40: #define PINYIN_CORRECT_ON_TO_ONG    (1U << 8)
On 2012/05/18 14:54:57, Peng wrote:
> A new line

Done.

https://codereview.appspot.com/6211062/diff/1/src/PyZyConst.h#newcode72
src/PyZyConst.h:72: #define PINYIN_FUZZY_UANG_UAN       PINYIN_FUZZY_ANG_AN
On 2012/05/18 14:54:57, Peng wrote:
> dito

Done.

Expand All Messages | Collapse All Messages