[google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch

Ported r187569 from google/gcc-4_6 branch.

2012-05-11  Han Shen  <shenhan@google.com>

        Backport from mainline.
        2012-05-01  Richard Earnshaw  <rearnsha@arm.com>

        * arm/linux-eabi.h (GLIBC_DYNAMIC_LINKER_DEFAULT): Avoid ifdef
        comparing enumeration values.  Update comments.

        2012-04-26  Michael Hope  <michael.hope@linaro.org>
                    Richard Earnshaw  <rearnsha@arm.com>

        * config/arm/linux-eabi.h (GLIBC_DYNAMIC_LINKER_SOFT_FLOAT): Define.
        (GLIBC_DYNAMIC_LINKER_HARD_FLOAT): Define.
        (GLIBC_DYNAMIC_LINKER_DEFAULT): Define.
        (GLIBC_DYNAMIC_LINKER): Redefine to use the hard float path.

[shenhan, 2012-05-16 01:02:26]

Hi Amhad and Jing, could you take a look at this CL at
http://codereview.appspot.com/6210060/

Thanks,
-Han

[asharif1, 2012-05-16 17:27:59]

On 2012/05/16 01:02:26, shenhan wrote:
> Hi Amhad and Jing, could you take a look at this CL at
> http://codereview.appspot.com/6210060/
> 
> Thanks,
> -Han

Shouldn't this have a corresponding ChangeLog entry and a
ChangeLog.google-gcc-4_6 entry?

[shenhan, 2012-05-16 22:11:08]

On 2012/05/16 17:27:59, asharif1 wrote:
> On 2012/05/16 01:02:26, shenhan wrote:
> > Hi Amhad and Jing, could you take a look at this CL at
> > http://codereview.appspot.com/6210060/
> > 
> > Thanks,
> > -Han
> 
> Shouldn't this have a corresponding ChangeLog entry and a
> ChangeLog.google-gcc-4_6 entry?

Hi Ahmad, thanks!

Done recreating the patch from "svn merge -c".

Regards,
-Han

[asharif1, 2012-05-16 22:54:19]

On 2012/05/16 22:11:08, shenhan wrote:
> On 2012/05/16 17:27:59, asharif1 wrote:
> > On 2012/05/16 01:02:26, shenhan wrote:
> > > Hi Amhad and Jing, could you take a look at this CL at
> > > http://codereview.appspot.com/6210060/
> > > 
> > > Thanks,
> > > -Han
> > 
> > Shouldn't this have a corresponding ChangeLog entry and a
> > ChangeLog.google-gcc-4_6 entry?
> 
> Hi Ahmad, thanks!
> 
> Done recreating the patch from "svn merge -c".
> 
> Regards,
> -Han

Thanks a lot, shenhan.

lgtm.

[jingyu, 2012-05-16 23:22:19]

In my opinion, gcc/ChangeLog is for upstream commits only.
It is fine that you want to port upstream gcc/ChangeLog as well. Just remove
your identities
+2012-05-11  Han Shen  <shenhan@google.com>
+
+	Backported r187569 from branches/google/gcc-4_6.

LGTM
On 2012/05/16 22:54:19, asharif1 wrote:
> On 2012/05/16 22:11:08, shenhan wrote:
> > On 2012/05/16 17:27:59, asharif1 wrote:
> > > On 2012/05/16 01:02:26, shenhan wrote:
> > > > Hi Amhad and Jing, could you take a look at this CL at
> > > > http://codereview.appspot.com/6210060/
> > > > 
> > > > Thanks,
> > > > -Han
> > > 
> > > Shouldn't this have a corresponding ChangeLog entry and a
> > > ChangeLog.google-gcc-4_6 entry?
> > 
> > Hi Ahmad, thanks!
> > 
> > Done recreating the patch from "svn merge -c".
> > 
> > Regards,
> > -Han
> 
> Thanks a lot, shenhan.
> 
> lgtm.

[Diego Novillo, 2012-05-16 23:30:28]

On 12-05-16 19:22 , jingyu@google.com wrote:
> In my opinion, gcc/ChangeLog is for upstream commits only.
> It is fine that you want to port upstream gcc/ChangeLog as well. Just
> remove your identities
> +2012-05-11 Han Shen <shenhan@google.com>
> +
> + Backported r187569 from branches/google/gcc-4_6.

The convention for branches is that all the commits to them should get 
ChangeLog entries in the file ChangeLog.<branch-tag>

where <branch-tag> is generally the basename of the branch URL, though 
it is sometimes changed slightly.  In the google branches we use the 
convention 'google-<name>' for all the branches under google/*


Diego.

[shenhan, 2012-05-16 23:49:10]

On 2012/05/16 23:30:28, Diego Novillo wrote:
> On 12-05-16 19:22 , mailto:jingyu@google.com wrote:
> > In my opinion, gcc/ChangeLog is for upstream commits only.
> > It is fine that you want to port upstream gcc/ChangeLog as well. Just
> > remove your identities
> > +2012-05-11 Han Shen <mailto:shenhan@google.com>
> > +
> > + Backported r187569 from branches/google/gcc-4_6.
> 
> The convention for branches is that all the commits to them should get 
> ChangeLog entries in the file ChangeLog.<branch-tag>
> 
> where <branch-tag> is generally the basename of the branch URL, though 
> it is sometimes changed slightly.  In the google branches we use the 
> convention 'google-<name>' for all the branches under google/*
> 
> 
> Diego.

Thanks, Jing and Diego.

Reverted gcc/ChangeLog.

Regards,
-Han

[shenhan, 2012-05-17 16:27:07]

Hi, ok for approval?

Thanks,
-Han

On Wed, May 16, 2012 at 4:49 PM,  <shenhan@google.com> wrote:
> On 2012/05/16 23:30:28, Diego Novillo wrote:
>
>> On 12-05-16 19:22 , mailto:jingyu@google.com wrote:
>> > In my opinion, gcc/ChangeLog is for upstream commits only.
>> > It is fine that you want to port upstream gcc/ChangeLog as well.
>
> Just
>>
>> > remove your identities
>> > +2012-05-11 Han Shen <mailto:shenhan@google.com>
>>
>> > +
>> > + Backported r187569 from branches/google/gcc-4_6.
>
>
>> The convention for branches is that all the commits to them should get
>
>
>> ChangeLog entries in the file ChangeLog.<branch-tag>
>
>
>> where <branch-tag> is generally the basename of the branch URL, though
>
>
>> it is sometimes changed slightly.  In the google branches we use the
>> convention 'google-<name>' for all the branches under google/*
>
>
>
>> Diego.
>
>
> Thanks, Jing and Diego.
>
> Reverted gcc/ChangeLog.
>
> Regards,
> -Han
>
> http://codereview.appspot.com/6210060/



-- 
Han Shen |  Software Engineer |  shenhan@google.com |  +1-650-440-3330

[Diego Novillo, 2012-05-17 16:39:45]

On 12-05-17 12:27 , Han Shen(沈涵) wrote:
> Hi, ok for approval?

OK.


Diego.