Issue 6209094: environs/ec2: add public bucket field to configuration.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rog

Modified:
11 years, 11 months ago

Reviewers:
mp+107040

Visibility:
Public.

Description

environs/ec2: add public bucket field to configuration. https://code.launchpad.net/~rogpeppe/juju/go-ec2-public-bucket/+merge/107040 Requires: https://code.launchpad.net/~rogpeppe/juju/go-ec2-instance-spec/+merge/105384 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: add public bucket field to configuration. #

Total comments: 4

Patch Set 3 : environs/ec2: add public bucket field to configuration. #

Patch Set 4 : environs/ec2: add public bucket field to configuration. #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -49 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/config.go	View		4 chunks	+4 lines, -0 lines	0 comments	Download
M	environs/ec2/config_test.go	View		2 chunks	+19 lines, -9 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1 2 3	3 chunks	+5 lines, -1 line	0 comments	Download
M	environs/ec2/export_test.go	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	environs/ec2/live_test.go	View	1 2	3 chunks	+25 lines, -1 line	0 comments	Download
M	environs/ec2/local_test.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	environs/ec2/state.go	View		2 chunks	+0 lines, -36 lines	0 comments	Download
M	environs/ec2/storage.go	View		1 chunk	+38 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6209094/diff/2001/environs/ec2/ec2.go File environs/ec2/ec2.go (right): https://codereview.appspot.com/6209094/diff/2001/environs/ec2/ec2.go#newcode46 environs/ec2/ec2.go:46: publicStorage *storage // optional. Please sync up with ...

11 years, 11 months ago (2012-05-23 20:44:37 UTC) #2

rog

Please take a look. https://codereview.appspot.com/6209094/diff/2001/environs/ec2/export_test.go File environs/ec2/export_test.go (right): https://codereview.appspot.com/6209094/diff/2001/environs/ec2/export_test.go#newcode37 environs/ec2/export_test.go:37: func DeleteStorage(s environs.Storage) error { ...

11 years, 11 months ago (2012-05-24 10:40:06 UTC) #3

rog

https://codereview.appspot.com/6209094/diff/2001/environs/ec2/ec2.go File environs/ec2/ec2.go (right): https://codereview.appspot.com/6209094/diff/2001/environs/ec2/ec2.go#newcode46 environs/ec2/ec2.go:46: publicStorage *storage // optional. On 2012/05/23 20:44:37, niemeyer wrote: ...

11 years, 11 months ago (2012-05-24 10:42:26 UTC) #4

rog

11 years, 11 months ago (2012-05-24 14:31:01 UTC) #5

*** Submitted:

environs/ec2: add public bucket field to configuration.

R=niemeyer
CC=
https://codereview.appspot.com/6209094

Expand All Messages | Collapse All Messages