Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 6208066: Modal bevel operator

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by psy-fi
Modified:
10 years ago
Reviewers:
ideasman42, bf-committers
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This patch modifies the bevel operator slightly so that it becomes modal. Moving the mouse will modify the bevel factor and E/D keys will change the behavior of the tool

Patch Set 1 #

Patch Set 2 : fixes mentioned #

Patch Set 3 : Add support for inset, separate bmesh caching code. #

Total comments: 5

Patch Set 4 : Address issues pointed at during review #

Total comments: 14

Patch Set 5 : Address more issues pointed at during review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -55 lines) Patch
source/blender/editors/include/ED_mesh.h View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
source/blender/editors/include/ED_transform.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
source/blender/editors/mesh/editmesh_tools.c View 1 2 3 4 6 chunks +479 lines, -50 lines 0 comments Download
source/blender/editors/mesh/editmesh_utils.c View 1 2 3 4 1 chunk +45 lines, -0 lines 0 comments Download
source/blender/editors/mesh/mesh_ops.c View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
source/blender/editors/space_view3d/view3d_edit.c View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
source/blender/editors/transform/transform.c View 1 2 3 4 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10
psy-fi
10 years ago (2012-05-15 13:59:24 UTC) #1
psy-fi
On 2012/05/15 13:59:24, psy-fi wrote: Fix a few non-modal operator issues, duplicate just the bmesh ...
10 years ago (2012-05-15 15:04:55 UTC) #2
psy-fi
fixes mentioned
10 years ago (2012-05-15 15:06:03 UTC) #3
psy-fi
Add support for inset, separate bmesh caching code.
10 years ago (2012-05-15 22:05:26 UTC) #4
psy-fi
Also, add hotkey for inset (I). To change thickness move mouse, to change depth press ...
10 years ago (2012-05-15 22:07:00 UTC) #5
ideasman42
one main request - regarding storing copies of operator settings, other changes are knitpicks. http://codereview.appspot.com/6208066/diff/8001/source/blender/editors/mesh/editmesh_tools.c ...
10 years ago (2012-05-15 22:40:02 UTC) #6
psy-fi
Address issues pointed at during review
10 years ago (2012-05-16 10:23:39 UTC) #7
ideasman42
looks good, still some remaining knitpicks and one question. http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c File source/blender/editors/mesh/editmesh_tools.c (right): http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/editmesh_tools.c#newcode4309 source/blender/editors/mesh/editmesh_tools.c:4309: ...
10 years ago (2012-05-16 10:44:09 UTC) #8
psy-fi
Address more issues pointed at during review
10 years ago (2012-05-16 11:06:21 UTC) #9
psy-fi
10 years ago (2012-05-16 11:07:35 UTC) #10
http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/e...
File source/blender/editors/mesh/editmesh_tools.c (right):

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/e...
source/blender/editors/mesh/editmesh_tools.c:4653: static char str[] = "Confirm:
Enter/LClick, Cancel: (Esc/RClick), thickness: %f, depth (Ctrl to tweak): %f
(%s), Outset (O): (%s)";
On 2012/05/16 10:44:09, ideasman42 wrote:
> on topic of keymaps - this kind of string should be generated from modal
> keymaps. longer term todo.

Yes, I was thinking along the same lines too. That would be great to have.

http://codereview.appspot.com/6208066/diff/3002/source/blender/editors/mesh/e...
source/blender/editors/mesh/editmesh_tools.c:4923: RNA_def_boolean(ot->srna,
"use_relative_offset", TRUE, "Offset Relative", "Scale the offset by surrounding
geometry");
On 2012/05/16 10:44:09, ideasman42 wrote:
> why is this changed?

Because it is difficult to estimate a good absolute thickness when using screen
space mouse values. Changing to relative gives more predictable results. If the
user needs absolute values he usually will know the exact value and place it
manually.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b