Issue 6206104: environs/ec2: use signed URL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6206104: environs/ec2: use signed URL

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by rog

Modified:
11 years, 11 months ago

Reviewers:
mp+107000

Visibility:
Public.

Description

environs/ec2: use signed URL amazon tests now work correctly. https://code.launchpad.net/~rogpeppe/juju/go-ec2-use-signed-urls/+merge/107000 (do not edit description out of merge proposal)

Patch Set 2 : environs/ec2: use signed URL #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/ec2/storage.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fwereade

https://codereview.appspot.com/6206104/diff/1/environs/ec2/storage.go File environs/ec2/storage.go (right): https://codereview.appspot.com/6206104/diff/1/environs/ec2/storage.go#newcode59 environs/ec2/storage.go:59: // a year should be good enough. I'd prefer ...

11 years, 11 months ago (2012-05-23 14:03:22 UTC) #2

niemeyer

LGTM https://codereview.appspot.com/6206104/diff/1/environs/ec2/storage.go File environs/ec2/storage.go (right): https://codereview.appspot.com/6206104/diff/1/environs/ec2/storage.go#newcode59 environs/ec2/storage.go:59: // a year should be good enough. On ...

11 years, 11 months ago (2012-05-23 15:01:46 UTC) #3

rog

11 years, 11 months ago (2012-05-23 15:13:07 UTC) #4

*** Submitted:

environs/ec2: use signed URL

amazon tests now work correctly.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6206104

Expand All Messages | Collapse All Messages