Issue 6202055: environs/ec2: delete control bucket and contents when environment is destroyed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6202055: environs/ec2: delete control bucket and contents when environment is destroyed

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 12 months ago by rog

Modified:
11 years, 12 months ago

Reviewers:
mp+105001

Visibility:
Public.

Description

environs/ec2: delete control bucket and contents when environment is destroyed https://code.launchpad.net/~rogpeppe/juju/go-delete-bucket-2/+merge/105001 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: delete control bucket and contents when environment is destroyed (alternate version) #

Total comments: 2

Patch Set 3 : environs/ec2: delete control bucket and contents when environment is destroyed #

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -19 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1 2	1 chunk	+6 lines, -6 lines	0 comments	Download
M	environs/ec2/export_test.go	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	environs/ec2/live_test.go	View		2 chunks	+22 lines, -0 lines	0 comments	Download
M	environs/ec2/state.go	View	1 2	5 chunks	+53 lines, -13 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM, that looks nicer than the other version. https://codereview.appspot.com/6202055/diff/2001/environs/ec2/state.go File environs/ec2/state.go (right): https://codereview.appspot.com/6202055/diff/2001/environs/ec2/state.go#newcode75 environs/ec2/state.go:75: return ...

11 years, 12 months ago (2012-05-10 00:26:37 UTC) #2

rog

11 years, 12 months ago (2012-05-10 19:11:49 UTC) #3

*** Submitted:

environs/ec2: delete control bucket and contents when environment is destroyed

R=niemeyer
CC=
https://codereview.appspot.com/6202055

Expand All Messages | Collapse All Messages