s3test: add list bucket functionality.

s3test: add list bucket functionality.

also refactor tests to match ec2 structure
and gofmt on the source tree.

https://code.launchpad.net/~rogpeppe/goamz/s3-s3test-list-bucket/+merge/104583

(do not edit description out of merge proposal)

[rog, 2012-05-08 17:11:54]

Please take a look.

[rog, 2012-05-08 22:36:17]

Please take a look.

[niemeyer, 2012-05-09 01:08:24]

LGTM.. just a few comments.

https://codereview.appspot.com/6201062/diff/2001/s3/s3.go
File s3/s3.go (right):

https://codereview.appspot.com/6201062/diff/2001/s3/s3.go#newcode199
s3/s3.go:199: //     test2.html
Can we please have index1.html and index2.html here?

https://codereview.appspot.com/6201062/diff/2001/s3/s3test/server.go
File s3/s3test/server.go (right):

https://codereview.appspot.com/6201062/diff/2001/s3/s3test/server.go#newcode313
s3/s3test/server.go:313: sort.Sort(objs)
Why is this happening down here rather than right after the for loop?

https://codereview.appspot.com/6201062/diff/2001/s3/s3test/server.go#newcode314
s3/s3test/server.go:314: 
Either this line break should be removed or prefixes should be moved to right
before the for loop.

https://codereview.appspot.com/6201062/diff/2001/s3/s3test/server.go#newcode323
s3/s3test/server.go:323: name = obj.name[:len(prefix)+len(delimiter)+i]
That doesn't look right. If delimiter is "/", obj.name is "foo/bar/baz", and
prefix is "foo/ba", I doubt we want the reslut of name to be "r". Maybe that's
how it works, but I'll be surprised if nothing else.

https://codereview.appspot.com/6201062/diff/2001/s3/s3test/server.go#newcode340
s3/s3test/server.go:340: // Content contains only keys not found in
CommonPrefixes
s/Content/&s/?

[rog, 2012-05-09 19:24:05]

*** Submitted:

s3test: add list bucket functionality.

also refactor tests to match ec2 structure
and gofmt on the source tree.

R=niemeyer
CC=
https://codereview.appspot.com/6201062

https://codereview.appspot.com/6201062/diff/2001/s3/s3.go
File s3/s3.go (right):

https://codereview.appspot.com/6201062/diff/2001/s3/s3.go#newcode199
s3/s3.go:199: //     test2.html
On 2012/05/09 01:08:24, niemeyer wrote:
> Can we please have index1.html and index2.html here?

Done.

https://codereview.appspot.com/6201062/diff/2001/s3/s3test/server.go
File s3/s3test/server.go (right):

https://codereview.appspot.com/6201062/diff/2001/s3/s3test/server.go#newcode313
s3/s3test/server.go:313: sort.Sort(objs)
On 2012/05/09 01:08:24, niemeyer wrote:
> Why is this happening down here rather than right after the for loop?

Done.

https://codereview.appspot.com/6201062/diff/2001/s3/s3test/server.go#newcode314
s3/s3test/server.go:314: 
On 2012/05/09 01:08:24, niemeyer wrote:
> Either this line break should be removed or prefixes should be moved to right
> before the for loop.

Done.

https://codereview.appspot.com/6201062/diff/2001/s3/s3test/server.go#newcode323
s3/s3test/server.go:323: name = obj.name[:len(prefix)+len(delimiter)+i]
On 2012/05/09 01:08:24, niemeyer wrote:
> That doesn't look right. If delimiter is "/", obj.name is "foo/bar/baz", and
> prefix is "foo/ba", I doubt we want the reslut of name to be "r". Maybe that's
> how it works, but I'll be surprised if nothing else.

correct as is, as discussed. moved the i to a more appropriate place.

https://codereview.appspot.com/6201062/diff/2001/s3/s3test/server.go#newcode340
s3/s3test/server.go:340: // Content contains only keys not found in
CommonPrefixes
On 2012/05/09 01:08:24, niemeyer wrote:
> s/Content/&s/?

Done.