code review 62000046: go.net/publicsuffix: print how much wiggle room we have...

go.net/publicsuffix: print how much wiggle room we have when encoding
the Public Suffix List as a compact sequence of uint32s.

Currently:
max children 366 (capacity 511)
max text offset 22351 (capacity 32767)
max text length 36 (capacity 63)
max hi 6406 (capacity 16383)
max lo 6399 (capacity 16383)

[nigeltao, 2014-02-12 02:53:15]

Hello dr.volker.dobler@gmail.com (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.net

[volker.dobler, 2014-02-12 08:24:24]

LGTM

https://codereview.appspot.com/62000046/diff/40001/publicsuffix/gen.go
File publicsuffix/gen.go (right):

https://codereview.appspot.com/62000046/diff/40001/publicsuffix/gen.go#newcod...
publicsuffix/gen.go:240: fmt.Fprintf(os.Stderr, "max text length %d (capacity
%d)\n", maxTextLength, 1<<nodesBitsTextLength-1)
Text length is a bit different from the rest of the values
as LDH labels are at most 63 bytes long. While the other
values might overflow if the public suffix list gets longer
overflowing text length would require a spec change before
longer labels could be added.

[nigeltao, 2014-02-13 00:15:22]

*** Submitted as
https://code.google.com/p/go/source/detail?r=b3b868a2af71&repo=net ***

go.net/publicsuffix: print how much wiggle room we have when encoding
the Public Suffix List as a compact sequence of uint32s.

Currently:
max children 366 (capacity 511)
max text offset 22351 (capacity 32767)
max text length 36 (capacity 63)
max hi 6406 (capacity 16383)
max lo 6399 (capacity 16383)

LGTM=dr.volker.dobler
R=dr.volker.dobler
CC=golang-codereviews
https://codereview.appspot.com/62000046