Issue 62000044: code review 62000044: ogle/probe: allow zero-sized reads and writes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 62000044: code review 62000044: ogle/probe: allow zero-sized reads and writes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by nigeltao

Modified:
10 years, 2 months ago

Reviewers:
r

CC:
r

Visibility:
Public.

Description

ogle/probe: allow zero-sized reads and writes. Go has zero-sized types, and it would be nice if validRead(&x, sizeof(x)) was true for any legit variable x.

Patch Set 1 #

Patch Set 2 : diff -r 239d84d9b130 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 239d84d9b130 https://code.google.com/p/ogle #

Patch Set 4 : diff -r b3f4d2b8af30 https://code.google.com/p/ogle #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	probe/addr_test.go	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
	M	probe/probe.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle

10 years, 2 months ago (2014-02-12 00:34:02 UTC) #1

nigeltao

10 years, 2 months ago (2014-02-12 00:39:43 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=2a09d0b8adf8 ***

ogle/probe: allow zero-sized reads and writes.

Go has zero-sized types, and it would be nice if
validRead(&x, sizeof(x)) was true for any legit variable x.

LGTM=r
R=r
https://codereview.appspot.com/62000044

Expand All Messages | Collapse All Messages