Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1408)

Issue 6197072: optimizations for small drawRect calls

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by reed1
Modified:
11 years, 11 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com, caryclark1, bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

optimizations for small drawRect calls

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -26 lines) Patch
M src/core/SkCanvas.cpp View 1 2 3 4 5 3 chunks +37 lines, -26 lines 0 comments Download

Messages

Total messages: 6
reed1
Likely I will commit these piece-meal, but here is the sum of my experiments so ...
11 years, 11 months ago (2012-05-10 20:25:00 UTC) #1
reed1
~ 20% faster on linux (when I ran with -03 for both runs)
11 years, 11 months ago (2012-05-10 20:50:31 UTC) #2
TomH
The templates add a *lot* of code complexity to BlitRow_D32. Do they really yield that ...
11 years, 11 months ago (2012-05-10 20:53:50 UTC) #3
reed1
Good question about the value of the 1-3 tail. I will try expanding the test ...
11 years, 11 months ago (2012-05-10 20:57:12 UTC) #4
reed1
removed template for catching the tail n%4 counts
11 years, 11 months ago (2012-05-11 12:33:50 UTC) #5
reed1
11 years, 11 months ago (2012-05-11 14:40:28 UTC) #6
committing the simpler pieces separately, to isolate these if there are any
problems found.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b