Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4037)

Issue 6197060: Suppress some varargs win32-only conversion warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by scottmg
Modified:
11 years, 11 months ago
Reviewers:
wtc
Base URL:
http://git.chromium.org/chromium/deps/nss.git@master
Visibility:
Public.

Description

Suppress some varargs win32-only conversion warnings ..\..\third_party\nss\mozilla\nsprpub\pr\src\io\prprf.c(668) : warning C4133: '=' : incompatible types - from 'WCHAR *' to 'const char *' ..\..\third_party\nss\mozilla\nsprpub\pr\src\io\prprf.c(1007) : warning C4090: '=' : different 'const' qualifiers ..\..\third_party\nss\mozilla\security\nss\lib\pk11wrap\pk11load.c(486) : warning C4102: 'library_loaded' : unreferenced label BUG=126483 R=wtc@chromium.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : another warning for unreferenced label #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M nss.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
scottmg
11 years, 11 months ago (2012-05-08 00:31:37 UTC) #1
wtc
Thank you for the patch. I have a question for you. https://codereview.appspot.com/6197060/diff/1/nss.gyp File nss.gyp (right): ...
11 years, 11 months ago (2012-05-08 00:49:09 UTC) #2
scottmg
On 2012/05/08 00:49:09, wtc wrote: > Thank you for the patch. I have a question ...
11 years, 11 months ago (2012-05-08 00:55:06 UTC) #3
scottmg
11 years, 11 months ago (2012-05-08 03:23:47 UTC) #4
wtc fixing warnings in upstream code. closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b