code review 61970044: cmd/go: Ensure that linking with gccgo uses installed l...

cmd/go: Ensure that linking with gccgo uses installed libraries.

Under some circumstances, gccgoToolchain's ld can pass the path of
build artefacts that have been deleted to the link command.  This fixes
it, but it's a bit delicate; please read the long comment in the diff.

Fixes issue 7303.

[mwhudson, 2014-02-12 01:53:23]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2014-02-12 05:02:10]

On 2014/02/12 01:53:23, mwhudson wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go/

Point of order

Fixes issue 7303.

The capitalization and punctuation are important as automated tools which are
easily confused consume the commit messages.

[michael.hudson, 2014-02-12 20:42:00]

dave@cheney.net writes:

> On 2014/02/12 01:53:23, mwhudson wrote:
>> Hello mailto:golang-codereviews@googlegroups.com,
>
>> I'd like you to review this change to
>> https://code.google.com/p/go/
>
> Point of order
>
> Fixes issue 7303.
>
> The capitalization and punctuation are important as automated tools
> which are easily confused consume the commit messages.

Updated.

[rsc, 2014-03-05 19:32:07]

LGTM
please fix and re-hg mail

https://codereview.appspot.com/61970044/diff/40001/src/cmd/go/build.go
File src/cmd/go/build.go (right):

https://codereview.appspot.com/61970044/diff/40001/src/cmd/go/build.go#newcod...
src/cmd/go/build.go:1828: // When installing a binary and a package that it
depends on,
please take the time to write shorter comments. it will save time in the future
when people need to read them.

// Prefer the output of an install action to the output of a build action,
// because the install action will delete the output of the build action.
// Iterate over the list backward (reverse dependency order) so that we
// always see the install before the build.

[rsc, 2014-03-05 19:32:18]

R=rsc

[mwhudson, 2014-03-09 22:59:50]

Hello golang-codereviews@googlegroups.com, dave@cheney.net,
michael.hudson@canonical.com, rsc@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[rsc, 2014-03-13 02:32:52]

LGTM

[rsc, 2014-03-13 03:05:58]

*** Submitted as https://code.google.com/p/go/source/detail?r=017d82d5ef30 ***

cmd/go: use correct libraries during gccgo link

Under some circumstances, gccgoToolchain's ld can pass the path of
build outputs that have been deleted to the link command.

Fixes issue 7303.

LGTM=rsc
R=golang-codereviews, dave, michael.hudson, rsc
CC=golang-codereviews
https://codereview.appspot.com/61970044

Committer: Russ Cox <rsc@golang.org>