"output-wrapper" option for modules

[Ilia Mirkin, 2012-05-09 20:32:43]

IMO the move here is to repurpose my global scope name thing to use google's
pass rather than the passes that I added (before google had one).

So turning on global-scope-name should enable the right compilation option and
use the different wrapper (without with).

[aleksam241, 2012-05-09 20:44:19]

> So turning on global-scope-name should enable the right compilation option and
> use the different wrapper (without with).

You didn't suggest to *replace* this patch on modules output-wrapper with one on
global-scope-name implementation, did you?
I'm also gonna use modules output-wrapper as a convenient way for adding global
copyrights to all module builds.

[imirkin_alum.mit.edu, 2012-05-09 20:57:45]

Oh, I see. So the "wrapper" wouldn't be like (function(){bla})(), but
rather /** copyright */%output% sort of thing?

On Wed, May 9, 2012 at 4:44 PM,  <aleksam241@gmail.com> wrote:
>> So turning on global-scope-name should enable the right compilation
>
> option and
>>
>> use the different wrapper (without with).
>
>
> You didn't suggest to *replace* this patch on modules output-wrapper
> with one on global-scope-name implementation, did you?
> I'm also gonna use modules output-wrapper as a convenient way for adding
> global copyrights to all module builds.
>
> http://codereview.appspot.com/6195048/

[aleksam241, 2012-05-09 21:06:39]

> Oh, I see. So the "wrapper" wouldn't be like (function(){bla})(), but
> rather /** copyright */%output% sort of thing?

Yes.
If global-scope-name do all the dirty work (setting renamePrefixNamespace,
adding ns__=ns__||{} and outer function), the only thing I need now will be the
copyrights.
I just wanted a quick solution – output-wrapper is a general purpose solution
that is able to do all that (+renamePrefixNamespace using
experimental-compiler-options).

[bolinfest, 2012-05-09 22:14:11]

I apologize I haven't had a chance to follow up on this yet (I'm traveling,
so I'm not spending much time in front of my laptop).

Yes, the output-wrapper thing does not work on modules as you describe, but
I want to fix the thing that Ilia is talking about first. I am concerned
that ordinary people who try to do something like:

(function() {%output%})();

with modules will be confused why it breaks everything. Since this is the
type of wrapper most people are using, I don't think that output-wrapper
for modules adds a ton of value right now. The copyright thing at the top
of each module is nice, but doesn't add substantial functionality.

On Wed, May 9, 2012 at 5:06 PM, <aleksam241@gmail.com> wrote:

> Oh, I see. So the "wrapper" wouldn't be like (function(){bla})(), but
>> rather /** copyright */%output% sort of thing?
>>
>
> Yes.
> If global-scope-name do all the dirty work (setting
> renamePrefixNamespace, adding ns__=ns__||{} and outer function), the
> only thing I need now will be the copyrights.
> I just wanted a quick solution – output-wrapper is a general purpose
> solution that is able to do all that (+renamePrefixNamespace using
> experimental-compiler-options)**.
>
>
http://codereview.appspot.com/**6195048/<http://codereview.appspot.com/6195048/>
>