LGTM On the commit message, as the first line describe what the change was, not ...
10 years, 2 months ago
(2014-02-12 00:46:05 UTC)
#2
LGTM
On the commit message, as the first line describe what the change was, not just
that it fixed a bug. Also, keep the first line free of things like b/11436727;
you can put it later in the description, but not the short (50 character)
first-line description.
So the commit message for this one could be:
Require ASPX page to be a direct child of the Web
This fixes the behavior experienced in b/11436727 where the non-default view for
Lists could be served thinking they were ASPX pages.
On 2014/02/12 00:46:05, ejona wrote: > LGTM > > On the commit message, as the ...
10 years, 2 months ago
(2014-02-15 00:26:04 UTC)
#3
On 2014/02/12 00:46:05, ejona wrote:
> LGTM
>
> On the commit message, as the first line describe what the change was, not
just
> that it fixed a bug. Also, keep the first line free of things like b/11436727;
> you can put it later in the description, but not the short (50 character)
> first-line description.
>
> So the commit message for this one could be:
>
>
> Require ASPX page to be a direct child of the Web
>
> This fixes the behavior experienced in b/11436727 where the non-default view
for
> Lists could be served thinking they were ASPX pages.
Code Commit :
https://code.google.com/p/plexi/source/detail?r=af3ae25096e4797f63cc7b6f7d21c...
Issue 61950043: Fix for b/11436727 Non default view for Lists stick around in Index and served as ASPX pages
(Closed)
Created 10 years, 2 months ago by Tanmay Vartak
Modified 10 years, 2 months ago
Reviewers: ejona
Base URL:
Comments: 0