Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1256)

Issue 61950043: Fix for b/11436727 Non default view for Lists stick around in Index and served as ASPX pages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Tanmay Vartak
Modified:
6 years, 4 months ago
Reviewers:
ejona
CC:
connector-cr_google.com
Visibility:
Public.

Description

Fix for b/11436727 Non default view for Lists stick around in Index and served as ASPX pages

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java View 1 chunk +16 lines, -2 lines 0 comments Download
M test/com/google/enterprise/adaptor/sharepoint/SharePointAdaptorTest.java View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Tanmay Vartak
6 years, 5 months ago (2014-02-11 21:16:14 UTC) #1
ejona
LGTM On the commit message, as the first line describe what the change was, not ...
6 years, 5 months ago (2014-02-12 00:46:05 UTC) #2
Tanmay Vartak
6 years, 4 months ago (2014-02-15 00:26:04 UTC) #3
On 2014/02/12 00:46:05, ejona wrote:
> LGTM
> 
> On the commit message, as the first line describe what the change was, not
just
> that it fixed a bug. Also, keep the first line free of things like b/11436727;
> you can put it later in the description, but not the short (50 character)
> first-line description.
> 
> So the commit message for this one could be:
> 
> 
> Require ASPX page to be a direct child of the Web
> 
> This fixes the behavior experienced in b/11436727 where the non-default view
for
> Lists could be served thinking they were ASPX pages.

Code Commit :
https://code.google.com/p/plexi/source/detail?r=af3ae25096e4797f63cc7b6f7d21c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b