Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3658)

Issue 6193043: Fix MIDI output for Kievan (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by aleksandr.andreev
Modified:
7 years, 9 months ago
Reviewers:
benko.pal, Graham Percival, dak, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Fix MIDI output for Kievan Adding KievanStaff and KievanVoice for MIDI output of Kievan notation.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Adding contexts for Vaticana and Mensural #

Patch Set 3 : Adding Beam_performer for Vaticana and Mensural #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -10 lines) Patch
M ly/performer-init.ly View 1 2 5 chunks +64 lines, -10 lines 0 comments Download

Messages

Total messages: 12
aleksandr.andreev
Here is a patch that attempts to fix issues with MIDI playback of Kievan notation.
7 years, 9 months ago (2012-05-04 02:39:16 UTC) #1
Carl
Looks like it works, but I think it can (and should) be simplified. If it ...
7 years, 9 months ago (2012-05-04 02:59:06 UTC) #2
aleksandr.andreev
For whatever reason, \alias Staff and \alias Voice do not bring in the performers. If ...
7 years, 9 months ago (2012-05-04 12:59:32 UTC) #3
dak
http://codereview.appspot.com/6193043/diff/1/ly/performer-init.ly File ly/performer-init.ly (right): http://codereview.appspot.com/6193043/diff/1/ly/performer-init.ly#newcode88 ly/performer-init.ly:88: \consists "Dynamic_performer" On 2012/05/04 02:59:06, Carl wrote: > Again, ...
7 years, 9 months ago (2012-05-04 15:34:17 UTC) #4
aleksandr.andreev
On 2012/05/04 15:34:17, dak wrote: > Aliases are only relevant for properties, I think. The ...
7 years, 9 months ago (2012-05-04 16:48:11 UTC) #5
dak
On 2012/05/04 16:48:11, aleksandr.andreev wrote: > On 2012/05/04 15:34:17, dak wrote: > > Aliases are ...
7 years, 9 months ago (2012-05-04 16:49:01 UTC) #6
Carl
On 2012/05/04 16:48:11, aleksandr.andreev wrote: > Sorry, I'm a little green. Does this mean I ...
7 years, 9 months ago (2012-05-04 17:27:23 UTC) #7
benko.pal
hi Aleksandr, 2012/5/4 <aleksandr.andreev@gmail.com>: > For whatever reason, \alias Staff and \alias Voice do not ...
7 years, 9 months ago (2012-05-04 19:33:06 UTC) #8
aleksandr.andreev
On 2012/05/04 19:33:06, benko.pal wrote: > > would you fix Vaticana and Mensural too? > ...
7 years, 9 months ago (2012-05-05 01:00:28 UTC) #9
benko.pal
hi Aleksandr, > I've uploaded a patch that gets at Vaticana and Mensural as well. ...
7 years, 9 months ago (2012-05-05 16:58:22 UTC) #10
aleksandr.andreev
On 2012/05/05 16:58:22, benko.pal wrote: > thank you very much! please add Beam_performer too to ...
7 years, 9 months ago (2012-05-05 19:27:04 UTC) #11
Graham Percival
7 years, 9 months ago (2012-05-07 18:27:13 UTC) #12
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b