Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(140)

Issue 6190063: implement jujud initzk (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 12 months ago by dave
Modified:
11 years, 11 months ago
Reviewers:
mp+105250
Visibility:
Public.

Description

implement jujud initzk Rog has already done this, but he hasn't comitted it yet, and I needed it. https://code.launchpad.net/~dave-cheney/juju/go-jujud-initzk/+merge/105250 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : implement jujud initzk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/initzk.go View 2 chunks +2 lines, -3 lines 0 comments Download
M cmd/jujud/initzk_test.go View 1 1 chunk +39 lines, -1 line 0 comments Download

Messages

Total messages: 4
dave_cheney.net
Please take a look.
11 years, 12 months ago (2012-05-09 18:41:24 UTC) #1
fwereade
I'd prefer to have... *a* test for this, at least.
11 years, 12 months ago (2012-05-09 18:48:57 UTC) #2
niemeyer
LGTM. I'm happy to have this one line in without tests given that rog has ...
11 years, 12 months ago (2012-05-09 18:50:11 UTC) #3
dave_cheney.net
11 years, 11 months ago (2012-05-14 20:58:37 UTC) #4
*** Submitted:

implement jujud initzk

Rog has already done this, but he hasn't comitted it yet, and I needed it.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6190063
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b